On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
Alright, I think all the areas that this PR touches have been reviewed by area
experts.
-
PR Comment: https://git.openjdk.org/jdk/pull/14718#issueco
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
The changes in the security classes look fine to me.
-
Marked as reviewed by mullan (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14718#pu
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
Marked as reviewed by mli (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14718#pullrequestreview-1506596503
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
Our CI tests are fine with this change. That said, I'll wait for security-dev
to complete the review, and then wait for a few more days so that others could
also
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14718#pullrequestreview-1506190678
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
Marked as reviewed by mchung (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14718#pullrequestreview-1506186255
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14718#pullrequestreview-1506183994
On Thu, 29 Jun 2023 21:28:39 GMT, Joe Darcy wrote:
> Looks fine, but please give some time for others reviewers before pushing.
Absolutely!
Also, this PR contains a code change (a typo in an error message), which,
technically speaking, disqualifies the bug from being "noreg-doc" and requires
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
Looks fine, but please give some time for others reviewers before pushing.
-
Marked as reviewed by darcy (Reviewer).
PR Review: https://git.openjdk.
