On Fri, 28 Apr 2023 20:55:33 GMT, Kevin Driver wrote:
> Fix type-o and update returns message.
@seanjmullan @valeriepeng : see 57e7f9951d21fe2be6466e1c10f3b3cdd53e64b4
-
PR Comment: https://git.openjdk.org/jdk/pull/13729#issuecomment-1533708955
> Fix type-o and update returns message.
Kevin Driver has refreshed the contents of this pull request, and previous
commits have been removed. Incremental views are not available. The pull
request now contains two commits:
- address code review comments
- JDK-8305963 fix type-o and update ret
> Fix type-o and update returns message.
Kevin Driver has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains four additional commits since
the last revision:
On Fri, 28 Apr 2023 20:55:33 GMT, Kevin Driver wrote:
> Fix type-o and update returns message.
I agree with Sean/Valerie's comments. Otherwise, LGTM.
-
Marked as reviewed by wetmore (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13729#pullrequestreview-1410050561
On Mon, 1 May 2023 21:21:15 GMT, Valerie Peng wrote:
>> Fix type-o and update returns message.
>
> src/java.base/share/classes/java/security/Security.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 1996, 2022, 2023, Oracle and/or its affiliates. All
>> rights reserved.
>
> Seems incorrect to ha
On Fri, 28 Apr 2023 20:55:33 GMT, Kevin Driver wrote:
> Fix type-o and update returns message.
src/java.base/share/classes/java/security/Security.java line 2:
> 1: /*
> 2: * Copyright (c) 1996, 2022, 2023, Oracle and/or its affiliates. All
> rights reserved.
Seems incorrect to have 3 copyrig
On Fri, 28 Apr 2023 20:55:33 GMT, Kevin Driver wrote:
> Fix type-o and update returns message.
src/java.base/share/classes/java/security/Security.java line 705:
> 703: * @param key the key of the property being retrieved.
> 704: *
> 705: * @return the string value of the security
On Fri, 28 Apr 2023 20:55:33 GMT, Kevin Driver wrote:
> Fix type-o and update returns message.
Looks good
-
Marked as reviewed by coffeys (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13729#pullrequestreview-1406619770
