Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v4]

2023-04-13 Thread Wei-Jun Wang
IIUC there is no place to add a reviewer's name. As long as you follow the steps in https://openjdk.org/guide/#release-notes, someone reviews it, and the state becomes Delivered, I think it's done. Thanks, Weijun > On Apr 13, 2023, at 7:14 AM, Eirik Bjorsnos wrote: > > On Thu, 9 Mar 2023 18:5

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v4]

2023-04-13 Thread Eirik Bjorsnos
On Thu, 9 Mar 2023 18:50:42 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v4]

2023-03-09 Thread Eirik Bjorsnos
On Thu, 9 Mar 2023 18:50:42 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v4]

2023-03-09 Thread Weijun Wang
On Thu, 9 Mar 2023 18:50:42 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v3]

2023-03-09 Thread Eirik Bjorsnos
On Thu, 9 Mar 2023 17:24:39 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v4]

2023-03-09 Thread Eirik Bjorsnos
> The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-8242260](https://bugs.openjdk.org/browse/JDK-8242260). > > This

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v3]

2023-03-09 Thread Weijun Wang
On Thu, 9 Mar 2023 17:24:39 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v3]

2023-03-09 Thread Weijun Wang
On Thu, 9 Mar 2023 17:24:39 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v2]

2023-03-09 Thread Eirik Bjorsnos
On Thu, 9 Mar 2023 16:41:31 GMT, Weijun Wang wrote: > `src/jdk.jartool/share/classes/module-info.java` and `test/jdk/TEST.groups` > still reference `com.sun.jarsigner`. Well spotted, I have removed these references. I'm assuming the references in the jdk.compiler symbol tables will be updated

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v3]

2023-03-09 Thread Eirik Bjorsnos
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- > The `-altsigner` and `-altsignerpath` options in J

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v2]

2023-03-09 Thread Weijun Wang
On Mon, 6 Mar 2023 19:02:02 GMT, Eirik Bjorsnos wrote: >> The `-altsigner` and `-altsignerpath` options in JarSigner with the >> underlying `ContentSigner` mechanism were deprected in Java 9, for removal >> in Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), >> [JDK-824

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options

2023-03-06 Thread Eirik Bjorsnos
On Mon, 6 Mar 2023 18:52:52 GMT, Weijun Wang wrote: > BTW, you don't need to touch `jarsigner.1`. It is auto-generated and another > team maintains the source. Thanks, I was not aware. I have reverted the changes to this file and trust it will be updated through some other channel. --

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options [v2]

2023-03-06 Thread Eirik Bjorsnos
> The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-8242260](https://bugs.openjdk.org/browse/JDK-8242260). > > This

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options

2023-03-06 Thread Weijun Wang
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote: > The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-824226

Re: RFR: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options

2023-03-06 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote: > The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-824226

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Weijun Wang
On Wed, 1 Mar 2023 17:15:51 GMT, Sean Mullan wrote: > I would add more words to the title of the issue to cover the changes, ex: > "Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath > options" Seems better. I've updated the title of JBS issue and CSR. - PR: ht

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Sean Mullan
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote: > The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-824226

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Weijun Wang
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote: > The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-824226

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Weijun Wang
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote: > The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-824226

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Lance Andersen
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote: > The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-824226

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 11:46:26 GMT, Lance Andersen wrote: > For your spec changes, I might borrow the format I used in > [JDK-8193757](https://bugs.openjdk.org/browse/JDK-8193757) I updated the Specification section to use the list-style format from JDK-8193757. I also included a mention of the j

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Lance Andersen
On Wed, 1 Mar 2023 07:52:58 GMT, Eirik Bjorsnos wrote: > Suggested CSR: > > ### Compatibility Kind: > source, binary, behavioral > > ### Compatibility Risk > minimal > > ### Compatibility Risk Description > The APIs were deprecated in JDK 9 with no known existing use. The probability > that t

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Lance Andersen
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote: > The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-824226

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote: > The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 15. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-824226

Re: RFR: 8303410: Remove ContentSigner

2023-03-01 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 19:09:00 GMT, Eirik Bjorsnos wrote: > The `-altsigner` and `-altsignerpath` options in JarSigner with the > underlying `ContentSigner` mechanism were deprected in Java 9, for removal in > Java 16. See [JDK-8076535](https://bugs.openjdk.org/browse/JDK-8076535), > [JDK-824226