Re: RFR: 8299870: TLS record version check allows invalid records [v4]

2023-01-19 Thread Rajan Halade
On Tue, 17 Jan 2023 17:12:05 GMT, Matthew Donovan wrote: >> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version >> numbers. >> - Removed IllegalRecordVersion.java from ProblemList.txt >> >> Tested with jdk_security and jdk_security3 test groups. > > Matthew Donovan has

Re: RFR: 8299870: TLS record version check allows invalid records [v4]

2023-01-19 Thread Rajan Halade
On Tue, 10 Jan 2023 22:46:06 GMT, Rajan Halade wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed extra whitespace > > test/jdk/ProblemList.txt line 590: > >> 588: >> 589: javax/net/ssl/SSLEngine/TestAllS

Re: RFR: 8299870: TLS record version check allows invalid records [v4]

2023-01-17 Thread Matthew Donovan
> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version > numbers. > - Removed IllegalRecordVersion.java from ProblemList.txt > > Tested with jdk_security and jdk_security3 test groups. Matthew Donovan has updated the pull request incrementally with one additional commit

Re: RFR: 8299870: TLS record version check allows invalid records [v3]

2023-01-12 Thread Matthew Donovan
> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version > numbers. > - Removed IllegalRecordVersion.java from ProblemList.txt > > Tested with jdk_security and jdk_security3 test groups. Matthew Donovan has updated the pull request incrementally with two additional commit

Re: RFR: 8299870: TLS record version check allows invalid records [v3]

2023-01-12 Thread Rajan Halade
On Fri, 13 Jan 2023 00:28:32 GMT, Matthew Donovan wrote: >> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version >> numbers. >> - Removed IllegalRecordVersion.java from ProblemList.txt >> >> Tested with jdk_security and jdk_security3 test groups. > > Matthew Donovan has

Re: RFR: 8299870: TLS record version check allows invalid records [v2]

2023-01-12 Thread Xue-Lei Andrew Fan
On Thu, 12 Jan 2023 15:32:23 GMT, Matthew Donovan wrote: >> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version >> numbers. >> - Removed IllegalRecordVersion.java from ProblemList.txt >> >> Tested with jdk_security and jdk_security3 test groups. > > Matthew Donovan has

Re: RFR: 8299870: TLS record version check allows invalid records [v2]

2023-01-12 Thread Matthew Donovan
> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version > numbers. > - Removed IllegalRecordVersion.java from ProblemList.txt > > Tested with jdk_security and jdk_security3 test groups. Matthew Donovan has updated the pull request incrementally with three additional comm

Re: RFR: 8299870: TLS record version check allows invalid records

2023-01-11 Thread Xue-Lei Andrew Fan
On Wed, 11 Jan 2023 19:49:14 GMT, Matthew Donovan wrote: > > > If we need to support later, currently undefined, versions then is > > > IllegalRecordVersion a valid test? > > > That's the good question. It may worthy of further evaluation and the > > > test case could be removed if it is not va

Re: RFR: 8299870: TLS record version check allows invalid records

2023-01-11 Thread Matthew Donovan
On Tue, 10 Jan 2023 20:34:49 GMT, Xue-Lei Andrew Fan wrote: > > If we need to support later, currently undefined, versions then is > > IllegalRecordVersion a valid test? > That's the good question. It may worthy of further evaluation and the test > case could be removed if it is not valid. I r

Re: RFR: 8299870: TLS record version check allows invalid records

2023-01-10 Thread Rajan Halade
On Tue, 10 Jan 2023 18:59:30 GMT, Matthew Donovan wrote: > - Updated ProtocolVersion.isNegotiable() to check a bounded range of version > numbers. > - Removed IllegalRecordVersion.java from ProblemList.txt > > Tested with jdk_security and jdk_security3 test groups. test/jdk/ProblemList.txt li

Re: RFR: 8299870: TLS record version check allows invalid records

2023-01-10 Thread Xue-Lei Andrew Fan
On Tue, 10 Jan 2023 20:16:02 GMT, Matthew Donovan wrote: > > This update will introduce version negotiation issues. Per TLS spec, > > version 105.106 should be allowed and the version could be negotiated > > properly. When TLS 1.4 is defined later in the future, the code update here > > will c

Re: RFR: 8299870: TLS record version check allows invalid records

2023-01-10 Thread Matthew Donovan
On Tue, 10 Jan 2023 19:25:32 GMT, Xue-Lei Andrew Fan wrote: > This update will introduce version negotiation issues. Per TLS spec, version > 105.106 should be allowed and the version could be negotiated properly. When > TLS 1.4 is defined later in the future, the code update here will cause >

Re: RFR: 8299870: TLS record version check allows invalid records

2023-01-10 Thread Xue-Lei Andrew Fan
On Tue, 10 Jan 2023 18:59:30 GMT, Matthew Donovan wrote: > - Updated ProtocolVersion.isNegotiable() to check a bounded range of version > numbers. > - Removed IllegalRecordVersion.java from ProblemList.txt > > Tested with jdk_security and jdk_security3 test groups. This update will introduce