Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v4]

2022-12-15 Thread Rajan Halade
On Thu, 15 Dec 2022 16:04:32 GMT, Matthew Donovan wrote: >> This fix is intended to address various time-out errors in tests that use >> DTLSOverDatagram as a test template. Based on test output from those bugs >> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, >> JDK-8268899

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v3]

2022-12-15 Thread Matthew Donovan
On Thu, 15 Dec 2022 15:09:12 GMT, Jamil Nimeh wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> formatting changes > > test/jdk/javax/net/ssl/DTLS/InvalidRecords.java line 42: > >> 40: >> 41: /** >> 42: * Test

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v4]

2022-12-15 Thread Matthew Donovan
> This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), this fix: > > * refactors the class to only create one addi

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v3]

2022-12-15 Thread Jamil Nimeh
On Wed, 14 Dec 2022 18:41:35 GMT, Matthew Donovan wrote: >> This fix is intended to address various time-out errors in tests that use >> DTLSOverDatagram as a test template. Based on test output from those bugs >> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, >> JDK-8268899

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v3]

2022-12-14 Thread Matthew Donovan
> This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), this fix: > > * refactors the class to only create one addi

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v2]

2022-12-14 Thread Rajan Halade
On Tue, 13 Dec 2022 12:32:30 GMT, Matthew Donovan wrote: >> This fix is intended to address various time-out errors in tests that use >> DTLSOverDatagram as a test template. Based on test output from those bugs >> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, >> JDK-8268899

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v2]

2022-12-13 Thread Matthew Donovan
On Thu, 8 Dec 2022 19:40:12 GMT, Rajan Halade wrote: >> test/jdk/javax/net/ssl/DTLS/DTLSOverDatagram.java line 617: >> >>> 615: clientException = e; >>> 616: >>> 617: if (testCase.isGoodJob()) { >> >> Same here. Check if this is method is even used and what is the purpo

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template [v2]

2022-12-13 Thread Matthew Donovan
> This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), this fix: > > * refactors the class to only create one addi

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Thu, 8 Dec 2022 12:54:30 GMT, Matthew Donovan wrote: > I'm not completely comfortable marking them as duplicate because there are a > few different errors going on and I wasn't able to reproduce them. Can we > mark mark them as "cannot reproduce" and include a link to this fix? Since all of

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Thu, 8 Dec 2022 19:33:09 GMT, Rajan Halade wrote: >> This fix is intended to address various time-out errors in tests that use >> DTLSOverDatagram as a test template. Based on test output from those bugs >> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, >> JDK-8268899), t

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan wrote: > This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), th

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan wrote: > This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), th

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Rajan Halade
On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan wrote: > This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), th

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-08 Thread Matthew Donovan
On Wed, 7 Dec 2022 20:34:00 GMT, Rajan Halade wrote: > Since this fix will address intermittent failures from these 5 tests, can we > close those 5 bugs as duplicate of this fix? I'm not completely comfortable marking them as duplicate because there are a few different errors going on and I wa

Re: RFR: 8297798: Timeout with DTLSOverDatagram test template

2022-12-07 Thread Rajan Halade
On Wed, 7 Dec 2022 13:04:28 GMT, Matthew Donovan wrote: > This fix is intended to address various time-out errors in tests that use > DTLSOverDatagram as a test template. Based on test output from those bugs > (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887, > JDK-8268899), th