Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v4]

2022-12-05 Thread Jamil Nimeh
On Mon, 5 Dec 2022 22:05:51 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to also

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v4]

2022-12-05 Thread Anthony Scarpino
On Mon, 5 Dec 2022 22:05:51 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to also

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-05 Thread Volodymyr Paprotski
On Thu, 1 Dec 2022 18:23:45 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to also

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v4]

2022-12-05 Thread Volodymyr Paprotski
> There is now an intrinsic for Poly1305, which is only enabled on the > `engineUpdate([]byte)` path. This PR adds intrinsic support > `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). > > Fuzzing test expanded to also include ByteBuffer payloads. > > Performance is now matched: > >

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-05 Thread Anthony Scarpino
On Thu, 1 Dec 2022 18:23:45 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to also

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-05 Thread Jamil Nimeh
On Mon, 5 Dec 2022 18:22:00 GMT, Sandhya Viswanathan wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove comment > > @valeriepeng Could you please take a look at this PR? @sviswa7 I will be looking at t

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-05 Thread Sandhya Viswanathan
On Thu, 1 Dec 2022 18:23:45 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to also

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-01 Thread Sandhya Viswanathan
On Thu, 1 Dec 2022 18:23:45 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to also

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-01 Thread Sandhya Viswanathan
On Thu, 1 Dec 2022 18:23:45 GMT, Volodymyr Paprotski wrote: >> There is now an intrinsic for Poly1305, which is only enabled on the >> `engineUpdate([]byte)` path. This PR adds intrinsic support >> `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). >> >> Fuzzing test expanded to also

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-01 Thread Volodymyr Paprotski
> There is now an intrinsic for Poly1305, which is only enabled on the > `engineUpdate([]byte)` path. This PR adds intrinsic support > `engineUpdate(ByteBuffer)` (when the bytebuffer `hasArray`). > > Fuzzing test expanded to also include ByteBuffer payloads. > > Performance is now matched: > >

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-01 Thread Volodymyr Paprotski
On Tue, 29 Nov 2022 01:16:28 GMT, Sandhya Viswanathan wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove comment > > src/java.base/share/classes/com/sun/crypto/provider/Poly1305.java line 260: > >> 258

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-01 Thread Volodymyr Paprotski
On Thu, 24 Nov 2022 18:42:01 GMT, Jatin Bhateja wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove comment > > src/java.base/share/classes/com/sun/crypto/provider/Poly1305.java line 268: > >> 266:

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v3]

2022-12-01 Thread Volodymyr Paprotski
On Thu, 1 Dec 2022 18:41:42 GMT, Volodymyr Paprotski wrote: >> src/java.base/share/classes/com/sun/crypto/provider/Poly1305.java line 268: >> >>> 266: } else { >>> 267: while (blockMultipleLength > 0) { >>> 268: processBlock(buf, BLOCK_LENGTH); >> >> For nati

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations [v2]

2022-12-01 Thread Volodymyr Paprotski
> Regarding mainline: > - I decided not to 'unroll' the top while loop (i.e. `engineUpdate(byte[] > input, int offset, int len)` is unrolled) >- It is debatable which version is easier to understand. If this version > is 'too complex', I can unroll the top while loop. > - I do think this ver

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations

2022-11-28 Thread Sandhya Viswanathan
On Wed, 23 Nov 2022 23:33:32 GMT, Volodymyr Paprotski wrote: > Regarding mainline: > - I decided not to 'unroll' the top while loop (i.e. `engineUpdate(byte[] > input, int offset, int len)` is unrolled) >- It is debatable which version is easier to understand. If this version > is 'too comp

Re: RFR: 8297379: Enable the ByteBuffer path of Poly1305 optimizations

2022-11-24 Thread Jatin Bhateja
On Wed, 23 Nov 2022 23:33:32 GMT, Volodymyr Paprotski wrote: > Regarding mainline: > - I decided not to 'unroll' the top while loop (i.e. `engineUpdate(byte[] > input, int offset, int len)` is unrolled) >- It is debatable which version is easier to understand. If this version > is 'too comp