On Fri, 18 Nov 2022 16:02:31 GMT, Weijun Wang wrote:
> Sure, you can choose your style. It's just that the original test was able to
> use multiple algorithm names in a single class but your enhancement abandoned
> this feature.
Did you refer to other bench case, like Signatures.java where I
On Sun, 13 Nov 2022 19:58:30 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> In the current key pair generation micro-benchmark, there is no cases for
> `EdDSA`, `XDH`, and `RSASSA-PSS`. This PR is trying to add these algorithms.
>
> BTW, here is the benchmarkin
On Thu, 17 Nov 2022 16:23:03 GMT, Weijun Wang wrote:
> If "DSA" and "DH" can be grouped inside a single class, is it also possible
> to group "RSA" and "RSASSA-PSS", and "XDH" and "EdDSA"?
The sub-class name appears in the he benchmark result (See `EC` in
`KeyPairGeneratorBench.EC.generateKeyP
On Sun, 13 Nov 2022 19:58:30 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> In the current key pair generation micro-benchmark, there is no cases for
> `EdDSA`, `XDH`, and `RSASSA-PSS`. This PR is trying to add these algorithms.
>
> BTW, here is the benchmarkin
On Wed, 16 Nov 2022 21:28:37 GMT, Weijun Wang wrote:
> I was wondering if secure random generation could be sometimes fast and
> sometimes slow. I'm also not sure about how NativePRNG behaves in a
> multi-thread environment.
I see your point. But it is still part of the key generation. Measu
On Wed, 16 Nov 2022 20:55:45 GMT, Xue-Lei Andrew Fan wrote:
> > The generation might depend on secure randoms a lot. How about create a
> > simple `SecureRandom` that is fast and does not depend on any external
> > entropy source?
>
> The secure random generation is part of the key generation.
On Wed, 16 Nov 2022 20:46:00 GMT, Weijun Wang wrote:
> The generation might depend on secure randoms a lot. How about create a
> simple `SecureRandom` that is fast and does not depend on any external
> entropy source?
The secure random generation is part of the key generation. It may be not t
On Wed, 16 Nov 2022 20:57:23 GMT, Xue-Lei Andrew Fan wrote:
> > Maybe you can do the same with the signature benchmark as well.
> > Unfortunately it has already been integrated.
>
> What do you mean with "the same"? secure random?
Yes, the secure random that can be provided in `initSign`.
---
On Sun, 13 Nov 2022 19:58:30 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> In the current key pair generation micro-benchmark, there is no cases for
> `EdDSA`, `XDH`, and `RSASSA-PSS`. This PR is trying to add these algorithms.
>
> BTW, here is the benchmarkin
