Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v10]

2023-12-12 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v9]

2023-12-11 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v8]

2023-12-11 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v7]

2023-12-11 Thread Sean Coffey
On Fri, 8 Dec 2023 19:07:27 GMT, Ben Perez wrote: >> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to >> use same debug printing format for X.509 serial numbers. The changes are: >> - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is >> `Serial nu

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v7]

2023-12-08 Thread Sean Mullan
On Fri, 8 Dec 2023 19:07:27 GMT, Ben Perez wrote: >> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to >> use same debug printing format for X.509 serial numbers. The changes are: >> - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is >> `Serial nu

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v7]

2023-12-08 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v6]

2023-12-05 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v5]

2023-12-05 Thread Sean Coffey
On Mon, 4 Dec 2023 21:00:47 GMT, Ben Perez wrote: >> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to >> use same debug printing format for X.509 serial numbers. The changes are: >> - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is >> `Serial nu

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v5]

2023-12-04 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v4]

2023-11-29 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v3]

2023-11-29 Thread Sean Mullan
On Wed, 29 Nov 2023 19:12:20 GMT, Ben Perez wrote: >> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to >> use same debug printing format for X.509 serial numbers. The changes are: >> - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is >> `Serial n

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v3]

2023-11-29 Thread Ben Perez
> Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug > printing format for X.509 serial numbers. The format in `SSLLogger.java` is > slightly different but now uses the `toString` method in `SerialNumber.java` > for better readability. Ben Perez has updated the pull reque

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v2]

2023-11-29 Thread Sean Mullan
On Tue, 28 Nov 2023 20:07:22 GMT, Ben Perez wrote: >> Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug >> printing format for X.509 serial numbers. The format in `SSLLogger.java` is >> slightly different but now uses the `toString` method in `SerialNumber.java` >> for

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers

2023-11-29 Thread Sean Mullan
On Tue, 28 Nov 2023 10:53:51 GMT, Sean Coffey wrote: > for clarity - can you include before and after examples of the serial numbers > printed from each change ? Yes, I think that would be useful. Also you will need to add a `noreg` label to the bug since you are not including a test (which I

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v2]

2023-11-28 Thread Ben Perez
> Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug > printing format for X.509 serial numbers. The format in `SSLLogger.java` is > slightly different but now uses the `toString` method in `SerialNumber.java` > for better readability. Ben Perez has updated the pull reque

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers

2023-11-28 Thread Sean Mullan
On Mon, 27 Nov 2023 21:45:23 GMT, Ben Perez wrote: > Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug > printing format for X.509 serial numbers. The format in `SSLLogger.java` is > slightly different but now uses the `toString` method in `SerialNumber.java` > for bett

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers

2023-11-28 Thread Sean Coffey
On Mon, 27 Nov 2023 21:45:23 GMT, Ben Perez wrote: > Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug > printing format for X.509 serial numbers. The format in `SSLLogger.java` is > slightly different but now uses the `toString` method in `SerialNumber.java` > for bett