Re: RFR: 8295068: SSLEngine throws NPE parsing CertificateRequests [v2]

2023-07-06 Thread Xue-Lei Andrew Fan
On Thu, 6 Jul 2023 15:52:00 GMT, Kevin Driver wrote: >> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a >> `ClientCertificateType`; rather than throwing the `NPE`, we now ignore an >> `id` which does match a `ClientCertificateType`. > > Kevin Driver has updated the pul

Re: RFR: 8295068: SSLEngine throws NPE parsing CertificateRequests [v2]

2023-07-06 Thread Kevin Driver
> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a > `ClientCertificateType`; rather than throwing the `NPE`, we now throw an > `IllegalArgumentException`. This does not seem to be a scenario where > recovery is possible or desired, so the `IAE` should be the proper beha

Re: RFR: 8295068: SSLEngine throws NPE parsing CertificateRequests

2023-07-06 Thread Kevin Driver
On Thu, 6 Jul 2023 07:05:46 GMT, Xue-Lei Andrew Fan wrote: >> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a >> `ClientCertificateType`; rather than throwing the `NPE`, we now throw an >> `IllegalArgumentException`. This does not seem to be a scenario where >> recove

Re: RFR: 8295068: SSLEngine throws NPE parsing CertificateRequests

2023-07-06 Thread Xue-Lei Andrew Fan
On Wed, 5 Jul 2023 20:25:26 GMT, Kevin Driver wrote: > JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a > `ClientCertificateType`; rather than throwing the `NPE`, we now throw an > `IllegalArgumentException`. This does not seem to be a scenario where > recovery is poss

Re: RFR: 8295068: SSLEngine throws NPE parsing CertificateRequests

2023-07-05 Thread Andrey Turbanov
On Wed, 5 Jul 2023 20:25:26 GMT, Kevin Driver wrote: > JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a > `ClientCertificateType`; rather than throwing the `NPE`, we now throw an > `IllegalArgumentException`. This does not seem to be a scenario where > recovery is poss