Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]

2023-05-18 Thread Bradford Wetmore
On Thu, 18 May 2023 22:33:30 GMT, Bradford Wetmore wrote: >> > src="https://github.com/openjdk/jdk/assets/1783591/c549e612-5ec7-47ce-add5-828cf79c31d9";> > > Slacked with Kevin and pointed out locations. Slacked with Kevin and resolved my concern. - PR Review Comment: https://git.o

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]

2023-05-18 Thread Bradford Wetmore
On Thu, 18 May 2023 22:02:55 GMT, Kevin Driver wrote: >> This might be something on your end @bradfordwetmore. I opened this in my >> IDE and went to the end of the line... It was right under the "String >> clientAlias" capital "S". > > src="https://github.com/openjdk/jdk/assets/1783591/c549e6

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]

2023-05-18 Thread Kevin Driver
On Thu, 18 May 2023 21:52:37 GMT, Bradford Wetmore wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> all review comments applied > > src/java.base/share/classes/sun/security/ssl/CertificateRequest.java line 385: > >

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]

2023-05-18 Thread Kevin Driver
On Thu, 18 May 2023 22:00:35 GMT, Kevin Driver wrote: >> src/java.base/share/classes/sun/security/ssl/CertificateRequest.java line >> 385: >> >>> 383: X509ExtendedKeyManager km = >>> chc.sslContext.getX509KeyManager(); >>> 384: String clientAlias = null; >>> 385: >> >

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]

2023-05-18 Thread Bradford Wetmore
On Thu, 18 May 2023 17:49:07 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > all review comments applied src/java.base/share/cla

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]

2023-05-18 Thread Xue-Lei Andrew Fan
On Thu, 18 May 2023 17:49:07 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > all review comments applied Marked as reviewed by x

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]

2023-05-18 Thread Sean Mullan
On Thu, 18 May 2023 17:49:07 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > all review comments applied Marked as reviewed by m

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]

2023-05-18 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: all review comments applied - Changes: - all: https://git.openjdk.org/jdk/pull/13466/files - new: ht