Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v9]

2022-11-09 Thread Volodymyr Paprotski
On Tue, 8 Nov 2022 23:59:42 GMT, Vladimir Ivanov wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix 32-bit build > > src/java.base/share/classes/com/sun/crypto/provider/Poly1305.java line 175: > >> 173: >

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v9]

2022-11-09 Thread Volodymyr Paprotski
On Wed, 9 Nov 2022 15:55:53 GMT, Jatin Bhateja wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix 32-bit build > > src/hotspot/cpu/x86/vm_version_x86.cpp line 1181: > >> 1179: #ifdef _LP64 >> 1180: if (s

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v9]

2022-11-09 Thread Volodymyr Paprotski
On Wed, 9 Nov 2022 00:23:21 GMT, Vladimir Ivanov wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix 32-bit build > > src/hotspot/cpu/x86/macroAssembler_x86.hpp line 970: > >> 968: >> 969: void addmq(int

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v9]

2022-11-09 Thread Volodymyr Paprotski
On Wed, 9 Nov 2022 00:10:48 GMT, Vladimir Ivanov wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix 32-bit build > > src/hotspot/share/opto/library_call.cpp line 7014: > >> 7012: const TypeKlassPtr* rkla

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v9]

2022-11-09 Thread Jatin Bhateja
On Tue, 8 Nov 2022 23:21:58 GMT, Volodymyr Paprotski wrote: >> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 >> message blocks at a time. For more details, left a lot of comments in >> `macroAssembler_x86_poly.cpp`. >> >> - Added new KAT test for Poly1305 and a fuzz t

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v9]

2022-11-08 Thread Volodymyr Paprotski
On Wed, 9 Nov 2022 00:10:48 GMT, Vladimir Ivanov wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix 32-bit build > > src/hotspot/share/opto/library_call.cpp line 7014: > >> 7012: const TypeKlassPtr* rkla

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v9]

2022-11-08 Thread Vladimir Ivanov
On Tue, 8 Nov 2022 23:21:58 GMT, Volodymyr Paprotski wrote: >> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 >> message blocks at a time. For more details, left a lot of comments in >> `macroAssembler_x86_poly.cpp`. >> >> - Added new KAT test for Poly1305 and a fuzz t

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v9]

2022-11-08 Thread Volodymyr Paprotski
> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 > message blocks at a time. For more details, left a lot of comments in > `macroAssembler_x86_poly.cpp`. > > - Added new KAT test for Poly1305 and a fuzz test to compare intrinsic and > java. > - Would like to add an `I