On Thu, 20 Feb 2025 17:36:14 GMT, Mark Powers wrote:
>> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> nit
Marked as reviewed by valeriep (Reviewer).
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
nit
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23188/files
- new: https://git.openjdk.org/jdk/pull/2
On Wed, 12 Feb 2025 18:41:45 GMT, Valerie Peng wrote:
>> Maybe we should just state that ArrayIndexOutOfBoundsException is thrown if
>> `offset` or `len` is negative? The current wording for AIOOBE seems to
>> suggest that it covers the case when `offset` or `len` is too large. But
>> that is
On Wed, 12 Feb 2025 21:08:50 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge master
>> - review comments from Valerie and Sean
>> - first iteration
>
> src/ja
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
Mark Powers has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
- Merge master
- review comments from Valerie and Sean
- first iteration
-
Change
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
review comments from Valerie and Sean
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23188/files
- new:
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
I didn't see the CSR? Assuming it's not filed yet? We still need to file CSR
for documenting existing behavior, but no need to cover the syntax related
changes, e.g. to {@code }.
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java line 73:
> 71: * or {@code (iv.length - offset < len)}
> 72: * @throws ArrayIndexOutOfBoundsException if
On Tue, 21 Jan 2025 15:53:35 GMT, Sean Mullan wrote:
>> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
>
> src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java line 73:
>
>> 71: * or {@code (iv.length - offset < len)}
>> 72: * @throws ArrayIndexOutOfBoundsExce
On Wed, 12 Feb 2025 18:37:38 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java line 73:
>>
>>> 71: * or {@code (iv.length - offset < len)}
>>> 72: * @throws ArrayIndexOutOfBoundsException if {@code offset}
>>> 73: * or {@code len} index
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
Didn't get to this until today, will take a look. Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-2653089842
On Tue, 21 Jan 2025 16:29:06 GMT, Mark Powers wrote:
> So a CSR is needed even if the only change is to sync javadoc with the code?
Yes, because that is still considered a specification change to a public API.
-
PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-260523
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
So a CSR is needed even if the only change is to sync javadoc with the code?
-
PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-2605202927
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
@valeriepeng can you also review this? Thanks.
src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java line 73:
> 71: * or {@code (iv.length - offset < len)}
> 72:
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
This will need a CSR because you are adding a new exception to the
`RC5ParameterSpec` constructor.
-
PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-26
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
Looks good to me.
-
Marked as reviewed by jnimeh (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23188#pullrequestreview-2563531119
16 matches
Mail list logo
