Re: RFR: 8156715: TrustStoreManager does not buffer keystore input stream [v2]

2025-07-02 Thread Bradford Wetmore
On Mon, 23 Jun 2025 19:00:51 GMT, Artur Barashev wrote: >> Wrap the FileInputStream into a BufferedInputStream which reduces the number >> of actual file reads when loading a key store. > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last rev

Re: RFR: 8156715: TrustStoreManager does not buffer keystore input stream [v2]

2025-06-24 Thread Artur Barashev
On Mon, 23 Jun 2025 23:11:16 GMT, Anthony Scarpino wrote: > Add a no regression test label on the bug. Probably `noreg-hard` as it's > difficult to test. Done, thanks! - PR Comment: https://git.openjdk.org/jdk/pull/25920#issuecomment-3000536214

Re: RFR: 8156715: TrustStoreManager does not buffer keystore input stream [v2]

2025-06-23 Thread Anthony Scarpino
On Mon, 23 Jun 2025 19:00:51 GMT, Artur Barashev wrote: >> Wrap the FileInputStream into a BufferedInputStream which reduces the number >> of actual file reads when loading a key store. > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last rev

Re: RFR: 8156715: TrustStoreManager does not buffer keystore input stream [v2]

2025-06-23 Thread Artur Barashev
> Wrap the FileInputStream into a BufferedInputStream which reduces the number > of actual file reads when loading a key store. Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Update copyright - Changes: - all: http

Re: RFR: 8156715: TrustStoreManager does not buffer keystore input stream [v2]

2025-06-23 Thread Artur Barashev
On Mon, 23 Jun 2025 18:43:12 GMT, Artur Barashev wrote: >> src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java line 379: >> >>> 377: >>> 378: if (!"NONE".equals(descriptor.storeName)) { >>> 379: try (BufferedInputStream fis = >> >> Nit: >> `ks` is fo

Re: RFR: 8156715: TrustStoreManager does not buffer keystore input stream

2025-06-23 Thread Artur Barashev
On Mon, 23 Jun 2025 18:34:22 GMT, Mark Powers wrote: >> Wrap the FileInputStream into a BufferedInputStream which reduces the number >> of actual file reads when loading a key store. > > src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java line 379: > >> 377: >> 378:

Re: RFR: 8156715: TrustStoreManager does not buffer keystore input stream

2025-06-23 Thread Mark Powers
On Fri, 20 Jun 2025 20:21:19 GMT, Artur Barashev wrote: > Wrap the FileInputStream into a BufferedInputStream which reduces the number > of actual file reads when loading a key store. Update copyright date. src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java line 379: > 377: