On Fri, 26 Aug 2022 14:51:48 GMT, Xue-Lei Andrew Fan wrote:
>> I think many engineers use the `-Djavax.net.debug=all` option for TLS
>> debugging at moment. `-Djavax.net.debug=ssl` is pretty much broke. There's
>> an open bug for that IIRC.
>>
>> I revisited the ServerHello produce() code for
On Fri, 26 Aug 2022 12:03:33 GMT, Sean Coffey wrote:
> ... on your "preference of client or server suites" data point question
It is not expected to break the connection by changing the preference even
there are multiple key exchange algs. There may be bugs, but did you see
failures caus
On Fri, 26 Aug 2022 04:31:59 GMT, Xue-Lei Andrew Fan wrote:
>> @coffeys Before we go further, I think we'd better have a look if the
>> information added could help for debugging. I'm not sure of that now.
>>
>>> With the new debug data, we have some extra data points like the
>>> ciphersuite
On Thu, 25 Aug 2022 21:03:35 GMT, Xue-Lei Andrew Fan wrote:
>> @XueleiFan - I think it's fair to say that the current "no cipher suites in
>> common" exception message is misleading for some scenarios. If not
>> misleading, it's ambiguous. You could be dealing with a simple scenario
>> where
On Thu, 25 Aug 2022 20:00:45 GMT, Sean Coffey wrote:
>> Even the cipher suites are the same between client and server, it may still
>> fail with "no common in cipher suites" error. The cause of the bug is not
>> only about "no common in cipher suites" between client and server, but also
>> ab
On Wed, 24 Aug 2022 21:59:59 GMT, Xue-Lei Andrew Fan wrote:
>> The cipher suite enabled on the server side is not logged when "no common in
>> cipher suites" error is thrown. Hope the developer could find the difference
>> in the cipher suites between client and server.
>
> Even the cipher suit
On Wed, 24 Aug 2022 20:38:07 GMT, Weibing Xiao wrote:
>> Thanks for the comments. I'm not sure if it is really helpful for
>> developers to understand and debug the failure by reading the additionally
>> dumped cipher suites and/or key exchange configuration. Given the server
>> cipher suite
On Tue, 23 Aug 2022 21:48:46 GMT, Xue-Lei Andrew Fan wrote:
>> I think Weibing is trying to achieve a balance here - the current TLS logs
>> are quite verbose. I'm not sure if we need verbose SSLServerSocket info for
>> every server socket operation. The current approach is to print the
>> SSL
On Tue, 23 Aug 2022 20:03:19 GMT, Sean Coffey wrote:
>> So, do you want to make the log where the configuration happens? Logging in
>> one place cannot have the accuracy debug log where the problem happens, and
>> cannot easy the analysis of the debug. One just gets the configuration
>> info
On Mon, 22 Aug 2022 12:52:54 GMT, Sean Mullan wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add or remove the blank line according to the comments
>
> src/java.base/share/classes/sun/security/ssl/ServerHello.java
On Thu, 18 Aug 2022 15:36:43 GMT, Xue-Lei Andrew Fan wrote:
>> Intend to log all of the collected information in one place. It is easy for
>> the developer to see the configuration of the server socket. Previously when
>> the handshake is failing, no information is available for the server sock
On Tue, 23 Aug 2022 15:04:44 GMT, Weibing Xiao wrote:
>> Log the debugging info for server cipher suites when setting javax.net.debug
>> == ssl, handshake.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update the code ac
> Log the debugging info for server cipher suites when setting javax.net.debug
> == ssl, handshake.
Weibing Xiao has updated the pull request incrementally with one additional
commit since the last revision:
update the code according to review comments
-
Changes:
- all: https:
On Thu, 18 Aug 2022 14:05:38 GMT, Weibing Xiao wrote:
>> Log the debugging info for server cipher suites when setting javax.net.debug
>> == ssl, handshake.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add or remove the
On Wed, 17 Aug 2022 14:27:56 GMT, Xue-Lei Andrew Fan wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add or remove the blank line according to the comments
>
> src/java.base/share/classes/sun/security/ssl/ServerHel
> Log the debugging info for server cipher suites when setting javax.net.debug
> == ssl, handshake.
Weibing Xiao has updated the pull request incrementally with one additional
commit since the last revision:
add or remove the blank line according to the comments
-
Changes:
- a
On Wed, 17 Aug 2022 14:27:15 GMT, Xue-Lei Andrew Fan wrote:
>> Log the debugging info for server cipher suites when setting javax.net.debug
>> == ssl, handshake.
>
> src/java.base/share/classes/sun/security/ssl/ServerHello.java line 416:
>
>> 414:
>> 415: List legacySuites = new Li
On Wed, 17 Aug 2022 14:25:40 GMT, Xue-Lei Andrew Fan wrote:
>> Log the debugging info for server cipher suites when setting javax.net.debug
>> == ssl, handshake.
>
> src/java.base/share/classes/sun/security/ssl/ServerHello.java line 409:
>
>> 407: if (shc.sslConfig.preferLocalCipher
On Wed, 17 Aug 2022 14:25:40 GMT, Xue-Lei Andrew Fan wrote:
>> Log the debugging info for server cipher suites when setting javax.net.debug
>> == ssl, handshake.
>
> src/java.base/share/classes/sun/security/ssl/ServerHello.java line 409:
>
>> 407: if (shc.sslConfig.preferLocalCipher
On Wed, 3 Aug 2022 15:40:54 GMT, Weibing Xiao wrote:
> Log the debugging info for server cipher suites when setting javax.net.debug
> == ssl, handshake.
src/java.base/share/classes/sun/security/ssl/ServerHello.java line 409:
> 407: if (shc.sslConfig.preferLocalCipherSuites) {
> 408
On Mon, 8 Aug 2022 15:59:29 GMT, Sean Coffey wrote:
>> Log the debugging info for server cipher suites when setting javax.net.debug
>> == ssl, handshake.
>
> src/java.base/share/classes/sun/security/ssl/ServerHello.java line 440:
>
>> 438: }
>> 439:
>> 440: if (
On Wed, 3 Aug 2022 15:40:54 GMT, Weibing Xiao wrote:
> Log the debugging info for server cipher suites when setting javax.net.debug
> == ssl, handshake.
src/java.base/share/classes/sun/security/ssl/ServerHello.java line 440:
> 438: }
> 439:
> 440: if (sun.secur
On Wed, 3 Aug 2022 15:40:54 GMT, Weibing Xiao wrote:
> Log the debugging info for server cipher suites when setting javax.net.debug
> == ssl, handshake.
The build and test for Oracle Mach5 were passed.
-
PR: https://git.openjdk.org/jdk/pull/9731
23 matches
Mail list logo
