Re: RFR: 6383195: javax.crypto.spec.PBEKeySpec is not thread safe [v3]

2022-07-28 Thread Bradford Wetmore
> Simple fix to a long-standing threading bug to help clear the bug backlog. > > Without the synchronized, the test case fails almost immediately. > > Running JPRT with tier1/tier2. Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: 6383195: javax.crypto.spec.PBEKeySpec is not thread safe [v2]

2022-07-28 Thread Bradford Wetmore
> Simple fix to a long-standing threading bug to help clear the bug backlog. > > Without the synchronized, the test case fails almost immediately. > > Running JPRT with tier1/tier2. Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: 6383195: javax.crypto.spec.PBEKeySpec is not thread safe

2022-07-27 Thread Bradford Wetmore
On Thu, 28 Jul 2022 01:42:23 GMT, Weijun Wang wrote: > BTW, how often can you observe a test failure before the code change? Third time through the loop. Testing: ... java.lang.RuntimeException: Inconsistent Password: at PBEKeySpecRacing.lambda$main$0(PBEKeySpecRacing.java:61)

Re: RFR: 6383195: javax.crypto.spec.PBEKeySpec is not thread safe

2022-07-27 Thread Weijun Wang
On Wed, 27 Jul 2022 23:53:53 GMT, Bradford Wetmore wrote: > Simple fix to a long-standing threading bug to help clear the bug backlog. > > Without the synchronized, the test case fails almost immediately. > > Running JPRT with tier1/tier2. LGTM. BTW, how often can you observe a test failu