Re: On 8346720: Support Generic keys in SunPKCS11 SecretKeyFactory

Done. Thanks, Martin.- On Mon, Jan 13, 2025 at 10:27 AM Sean Mullan wrote: > > > On 1/12/25 9:11 PM, Martin Balao wrote: > > Done. I removed the Generic name Specification update request and added > > a reference to your CSR instead. > > You should also change the scope from "SE" to "JDK" now t

Re: On 8346720: Support Generic keys in SunPKCS11 SecretKeyFactory

On 1/12/25 9:11 PM, Martin Balao wrote: Done. I removed the Generic name Specification update request and added a reference to your CSR instead. You should also change the scope from "SE" to "JDK" now that there are no spec. changes. Also remove the words "and update the Standard Names doc

Re: On 8346720: Support Generic keys in SunPKCS11 SecretKeyFactory

Done. I removed the Generic name Specification update request and added a reference to your CSR instead. Thanks, Martin.- On Fri, Jan 10, 2025 at 6:36 PM Wei-Jun Wang wrote: > I’ve added the SecurityKeyFactort.Generic part into > https://bugs.openjdk.org/browse/JDK-8346997. You can remove your

Re: On 8346720: Support Generic keys in SunPKCS11 SecretKeyFactory

I’ve added the SecurityKeyFactort.Generic part into https://bugs.openjdk.org/browse/JDK-8346997. You can remove yours. Thanks, Weijun On Jan 9, 2025, at 10:06, Martin Balao wrote: If it's more clear or easier for you, we can do it. I've re-opened JDK-8346720. We will reference JDK-8346720 in

Re: On 8346720: Support Generic keys in SunPKCS11 SecretKeyFactory

If it's more clear or easier for you, we can do it. I've re-opened JDK-8346720. We will reference JDK-8346720 in PR #22215's commit for the code changes part. My understanding is that PR #22215 will now be blocked by JDK-8346720's CSR. We look forward to having the CSR for JDK-8346720 reviewed, s

Re: On 8346720: Support Generic keys in SunPKCS11 SecretKeyFactory

But JDK-8346720 does not sound like only spec change. It needs real code and a change to SunPKCS11 Provider doc (which is not a spec). This is my suggestion: 1. Re-open JDK-8346720, but you can cover the code change in PR #22215. 2. We will create a sub-task for it to update the SunPKCS11 Provid

Re: On 8346720: Support Generic keys in SunPKCS11 SecretKeyFactory

Hi Weijun, Happy new year to you as well! Thanks for the heads up. My understanding is that the spec changes will be done in JDK-8346997 and the code changes will be integrated as part of "8328119: Support HKDF in SunPKCS11 (Preview) (PR #22215)", so