Re: RFR: JDK-8312461 JNI warnings in SunMSCApi provider

2023-08-10 Thread Mark Powers
On Thu, 10 Aug 2023 05:59:50 GMT, Daniel Jeliński wrote: >> https://bugs.openjdk.org/browse/JDK-8312461 > > Please update the copyright year. @djelinski Thanks for noticing the copyright. - PR Comment: https://git.openjdk.org/jdk/pull/15113#issuecomment-1673395179

Re: RFR: JDK-8312461 JNI warnings in SunMSCApi provider [v2]

2023-08-10 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8312461 Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revisi

Re: RFR: JDK-8312461 JNI warnings in SunMSCApi provider [v2]

2023-08-10 Thread Daniel Jeliński
On Thu, 10 Aug 2023 14:48:54 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8312461 > > Mark Powers has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull

Re: RFR: JDK-8312461 JNI warnings in SunMSCApi provider

2023-08-09 Thread Daniel Jeliński
On Tue, 1 Aug 2023 21:08:49 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8312461 Marked as reviewed by djelinski (Reviewer). Please update the copyright year. - PR Review: https://git.openjdk.org/jdk/pull/15113#pullrequestreview-1571072631 PR Comment: https://git.

Re: RFR: JDK-8312461 JNI warnings in SunMSCApi provider

2023-08-09 Thread Mark Powers
On Wed, 9 Aug 2023 17:56:02 GMT, Valerie Peng wrote: >> https://bugs.openjdk.org/browse/JDK-8312461 > > Changes look good. > BTW, need to add noreg-xxx label to the bug. @valeriepeng Thanks for the review! - PR Comment: https://git.openjdk.org/jdk/pull/15113#issuecomment-167247617

Re: RFR: JDK-8312461 JNI warnings in SunMSCApi provider

2023-08-09 Thread Valerie Peng
On Tue, 1 Aug 2023 21:08:49 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8312461 Changes look good. BTW, need to add noreg-xxx label to the bug. - Marked as reviewed by valeriep (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15113#pullrequestreview-15702

Re: RFR: JDK-8312461 JNI warnings in SunMSCApi provider

2023-08-01 Thread Mark Powers
On Tue, 1 Aug 2023 21:08:49 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8312461 I was able to reproduce the problem with mach5 and verify that the WARNING was gone after the fix. The hardest thing about this bug was figuring out how to set `-Xcheck:jni` on the mach5 command l

RFR: JDK-8312461 JNI warnings in SunMSCApi provider

2023-08-01 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8312461 - Commit messages: - Merge - first iteration Changes: https://git.openjdk.org/jdk/pull/15113/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15113&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312461 Stats: 5 lines in 1