Re: RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-06 Thread Matthias Baesken
On Tue, 6 Jun 2023 07:15:08 GMT, Alan Bateman wrote: >> There are cases in the sctp coding where a function >> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing >> handleSocketErrorWithMessage) to provide more detail what failed. >> >> Additionally sctpHandleSocketError

Re: RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-06 Thread Matthias Baesken
On Tue, 6 Jun 2023 08:51:33 GMT, Daniel Fuchs wrote: > FWIW the changes look good to me. Thanks for looking into it. - PR Comment: https://git.openjdk.org/jdk/pull/14280#issuecomment-1578414732

Re: RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-06 Thread Daniel Fuchs
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote: > There are cases in the sctp coding where a function > sctpHandleSocketErrorWithMessage would be beneficial (similar to existing > handleSocketErrorWithMessage) to provide more detail what failed. > > Additionally sctpHandleSocketErrorW

Re: RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-06 Thread Alan Bateman
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote: > There are cases in the sctp coding where a function > sctpHandleSocketErrorWithMessage would be beneficial (similar to existing > handleSocketErrorWithMessage) to provide more detail what failed. > > Additionally sctpHandleSocketErrorW

Re: RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-06 Thread Matthias Baesken
On Tue, 6 Jun 2023 07:16:13 GMT, Alan Bateman wrote: > I see this was integrated without a reviewer in the area but I think the > changes are okay. Hi Alan, I think Christoph is very competent in the area. But should I look into the census next time for some special reviewer category (and whic

Re: RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-06 Thread Alan Bateman
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote: > There are cases in the sctp coding where a function > sctpHandleSocketErrorWithMessage would be beneficial (similar to existing > handleSocketErrorWithMessage) to provide more detail what failed. > > Additionally sctpHandleSocketErrorW

Re: RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-06 Thread Matthias Baesken
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote: > There are cases in the sctp coding where a function > sctpHandleSocketErrorWithMessage would be beneficial (similar to existing > handleSocketErrorWithMessage) to provide more detail what failed. > > Additionally sctpHandleSocketErrorW

Re: RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-05 Thread Christoph Langer
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote: > There are cases in the sctp coding where a function > sctpHandleSocketErrorWithMessage would be beneficial (similar to existing > handleSocketErrorWithMessage) to provide more detail what failed. > > Additionally sctpHandleSocketErrorW

RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-02 Thread Matthias Baesken
There are cases in the sctp coding where a function sctpHandleSocketErrorWithMessage would be beneficial (similar to existing handleSocketErrorWithMessage) to provide more detail what failed. Additionally sctpHandleSocketErrorWithMessage was a bit modified (added errno handling for ENOTCONN fro