Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides [v4]

2022-12-05 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8293412 Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revis

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides [v3]

2022-11-30 Thread Bradford Wetmore
On Tue, 22 Nov 2022 22:14:07 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8293412 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > javadoc update Would you consider removing SHA1PRNG from sun/security/ssl/

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides [v3]

2022-11-22 Thread Mark Powers
On Tue, 22 Nov 2022 22:14:07 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8293412 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > javadoc update Verified with testing that /dev/urandom is used when overrid

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides [v3]

2022-11-22 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8293412 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: javadoc update - Changes: - all: https://git.openjdk.org/jdk/pull/10716/files - new: https://git.openjdk.org/jdk/pull/10716

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides [v2]

2022-11-15 Thread Daniel Jeliński
On Mon, 14 Nov 2022 23:01:13 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8293412 > > Mark Powers has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides [v2]

2022-11-14 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8293412 Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revisio

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-11-10 Thread Mark Powers
On Fri, 11 Nov 2022 01:10:54 GMT, Mark Powers wrote: >> test/jdk/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java line >> 29: >> >>> 27: * @summary NativeSeedGenerator is making 8192 byte read requests from >>> 28: * entropy pool on each init. >>> 29: * @run main/othe

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-11-10 Thread Mark Powers
On Mon, 31 Oct 2022 07:48:19 GMT, Daniel Jeliński wrote: >> https://bugs.openjdk.org/browse/JDK-8293412 > > test/jdk/java/security/SecureRandom/ApiTest.java line 56: > >> 54: >> 55: public static void main(String[] args) throws Exception { >> 56: System.setProperty("java.security.eg

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-10-31 Thread Daniel Jeliński
On Fri, 14 Oct 2022 21:49:07 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293412 I'm still verifying the jarsigner and the SecurityTools changes, but all of the other files actually need the EGD override. test/jdk/java/security/SecureRandom/ApiTest.java line 56: > 54: > 55:

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-10-28 Thread Xue-Lei Andrew Fan
On Fri, 14 Oct 2022 21:49:07 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293412 I think it is a good clean up so that the default one get used in testing. - Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.org/jdk/pull/10716

RFR: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-10-28 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8293412 - Commit messages: - Merge - second iteration - Merge - first iteration Changes: https://git.openjdk.org/jdk/pull/10716/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10716&range=00 Issue: https://bugs.openjdk.org/browse/JDK-

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-10-28 Thread Mark Powers
On Fri, 14 Oct 2022 21:49:07 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293412 No failures were noticed during mach5 and jtreg testing. - PR: https://git.openjdk.org/jdk/pull/10716