Re: RFR: JDK-8290887 Unused private method in TrustManagerFactoryImpl [v2]

2022-07-26 Thread Sean Mullan
On Tue, 26 Jul 2022 15:07:03 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8290887 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > second iteration Marked as reviewed by mullan (Reviewer). - P

Re: RFR: JDK-8290887 Unused private method in TrustManagerFactoryImpl [v2]

2022-07-26 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8290887 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: second iteration - Changes: - all: https://git.openjdk.org/jdk/pull/9616/files - new: https://git.openjdk.org/jdk/pull/9616

Re: RFR: JDK-8290887 Unused private method in TrustManagerFactoryImpl

2022-07-26 Thread Sean Mullan
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8290887 src/java.base/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java line 108: > 106: } > 107: > 108: /* I think you can also remove the `import java.io.*` on line 28 now that this

Re: RFR: JDK-8290887 Unused private method in TrustManagerFactoryImpl

2022-07-22 Thread Xue-Lei Andrew Fan
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8290887 Marked as reviewed by xuelei (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9616

Re: RFR: JDK-8290887 Unused private method in TrustManagerFactoryImpl

2022-07-22 Thread Mark Powers
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8290887 Thanks. - PR: https://git.openjdk.org/jdk/pull/9616

Re: RFR: JDK-8290887 Unused private method in TrustManagerFactoryImpl

2022-07-22 Thread Weijun Wang
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8290887 LGTM. - Marked as reviewed by weijun (Reviewer). PR: https://git.openjdk.org/jdk/pull/9616

RFR: JDK-8290887 unused private method in TrustManagerFactoryImpl

2022-07-22 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8290887 - Commit messages: - first iteration Changes: https://git.openjdk.org/jdk/pull/9616/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9616&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290887 Stats: 26 lines in 1 file chan