Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v2]

2022-07-27 Thread Valerie Peng
On Wed, 27 Jul 2022 11:41:07 GMT, Matthias Baesken wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Exception.java >> line 206: >> >>> 204: // potential matches >>> 205: if ((errorCode & 0x8000L) != 0) { >>> 206: // for unknown PK

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v3]

2022-07-27 Thread Valerie Peng
On Wed, 27 Jul 2022 11:40:02 GMT, Matthias Baesken wrote: >> The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the >> following PKCS11 exception (see attached jtr files of that bug) : >> >> Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 >> >> Unf

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v2]

2022-07-27 Thread Matthias Baesken
On Mon, 25 Jul 2022 21:27:34 GMT, Valerie Peng wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> do not add the deprecated CKR_COPY_PROHIBITED, handle vendor pkcs11 error >> codes differently > > src/jdk.crypto.

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v3]

2022-07-27 Thread Matthias Baesken
> The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the > following PKCS11 exception (see attached jtr files of that bug) : > > Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 > > Unfortunately the error code 0xCE534351 is currently not in the RV/er

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v2]

2022-07-25 Thread Valerie Peng
On Fri, 22 Jul 2022 10:22:39 GMT, Matthias Baesken wrote: >> The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the >> following PKCS11 exception (see attached jtr files of that bug) : >> >> Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 >> >> Unf

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v2]

2022-07-25 Thread Valerie Peng
On Fri, 22 Jul 2022 10:22:40 GMT, Matthias Baesken wrote: > Hi Valerie that sounds like a good idea, I adjusted the PR . Have you verified the new output and see if it addresses your need? I will also run the regression tests just to be safe. Thanks~ - PR: https://git.openjdk.org/

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v2]

2022-07-22 Thread Matthias Baesken
On Fri, 22 Jul 2022 10:22:39 GMT, Matthias Baesken wrote: >> The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the >> following PKCS11 exception (see attached jtr files of that bug) : >> >> Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 >> >> Unf

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes [v2]

2022-07-22 Thread Matthias Baesken
> The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the > following PKCS11 exception (see attached jtr files of that bug) : > > Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 > > Unfortunately the error code 0xCE534351 is currently not in the RV/er

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-21 Thread Valerie Peng
On Tue, 19 Jul 2022 13:14:17 GMT, Matthias Baesken wrote: > The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the > following PKCS11 exception (see attached jtr files of that bug) : > > Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 > > Unfortuna

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-21 Thread Matthias Baesken
On Wed, 20 Jul 2022 22:01:18 GMT, Valerie Peng wrote: > I don't think it's worthwhile to add deprecated error codes. As for vendor > specific error codes, I think they belong in a separate collection based on > which vendor/PKCS#11 library is used. Okay makes sense then we leave the deprecated

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-20 Thread Valerie Peng
On Tue, 19 Jul 2022 13:14:17 GMT, Matthias Baesken wrote: > The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the > following PKCS11 exception (see attached jtr files of that bug) : > > Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 > > Unfortuna

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-19 Thread Matthias Baesken
On Tue, 19 Jul 2022 20:37:09 GMT, Valerie Peng wrote: > None of the 3 proposed error codes in this PR is in the standard PKCS#11 > header files - two of them are vendor specific. For vendor specific error > code, such direct mapping may be incorrect. As for CKR_COPY_PROHIBITED, I > can't find

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-19 Thread Valerie Peng
On Tue, 19 Jul 2022 13:14:17 GMT, Matthias Baesken wrote: > The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the > following PKCS11 exception (see attached jtr files of that bug) : > > Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 > > Unfortuna

Re: RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-19 Thread Matthias Baesken
On Tue, 19 Jul 2022 13:14:17 GMT, Matthias Baesken wrote: > The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the > following PKCS11 exception (see attached jtr files of that bug) : > > Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 > > Unfortuna

RFR: JDK-8290532: Adjust PKCS11Exception and handle more PKCS11 error codes

2022-07-19 Thread Matthias Baesken
The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the following PKCS11 exception (see attached jtr files of that bug) : Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351 Unfortunately the error code 0xCE534351 is currently not in the RV/errorMap tabl