Re: RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-22 Thread Mark Powers
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8155039 Opened JDK-8290887 to fix a different issue while working on JDK-8155039. Closing JDK-8155039 as Will-Not-Fix. - PR: https://git.openjdk.org/jdk/pull/9542

Re: RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-22 Thread Mark Powers
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8155039 JDK-8290887 has been filed for the separate cleanup. - PR: https://git.openjdk.org/jdk/pull/9542

Re: RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-19 Thread Weijun Wang
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8155039 We can do them in a separate cleanup and close this one with Will-Not-Fix. Otherwise, you need to change the title of this bug to "cleanup something" and a historian will find it confusing on wha

Re: RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-19 Thread Mark Powers
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8155039 Can't say I disagree. That would leave removing the unused method from TrustManagerFactoryImpl.java and a couple of typos. - PR: https://git.openjdk.org/jdk/pull/9542

Re: RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-19 Thread Weijun Wang
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8155039 I'm not sure if this is worth doing. It looks like after the code change each of the 2 constructors is only used once by one of the 2 new `privilegedGetFileInputStream` methods, and then each new

RFR: JDK-8155039 Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2022-07-19 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8155039 - Commit messages: - fourth iteration - third iteration - second iteration - first iteration Changes: https://git.openjdk.org/jdk/pull/9542/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9542&range=00 Issue: https://bugs.open