Re: RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss [v4]

2025-10-26 Thread Sergey Bylokhov
> Please review the application of the `@Serial` annotation > ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the > java.security.jgss module to enable stricter compile-time checking of > serialization-related declarations. > > Example of a similar change https://github

Re: RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss [v3]

2025-10-23 Thread Sean Mullan
On Thu, 23 Oct 2025 22:33:42 GMT, Sergey Bylokhov wrote: >> src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Ktab.java >> line 87: >> >>> 85: @java.io.Serial >>> 86: private static final long serialVersionUID = 0L; >>> 87: private final int errorCo

Re: RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss [v3]

2025-10-23 Thread Sean Mullan
On Thu, 23 Oct 2025 22:47:56 GMT, Sean Mullan wrote: >>> `errorCode` should have `@Serial` too. >> >> I think you may have confused it with the `@serial` tag in Javadoc. This >> annotation can be applied to these methods/fields. >> * private void writeObject(java.io.ObjectOutputStream stream)

Re: RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss [v3]

2025-10-23 Thread Sean Mullan
On Thu, 23 Oct 2025 22:38:21 GMT, Sergey Bylokhov wrote: >> Please review the application of the `@Serial` annotation >> ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the >> java.security.jgss module to enable stricter compile-time checking of >> serialization-relate

Re: RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss [v3]

2025-10-23 Thread Sergey Bylokhov
On Thu, 23 Oct 2025 18:23:05 GMT, Sean Mullan wrote: >> Sergey Bylokhov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Replace java.io.Serial annotations with @Serial > > src/java.security.jgss/share/classes/sun/security/krb5/internal/K

Re: RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss [v3]

2025-10-23 Thread Sergey Bylokhov
> Please review the application of the `@Serial` annotation > ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the > java.security.jgss module to enable stricter compile-time checking of > serialization-related declarations. > > Example of a similar change https://github

Re: RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss [v2]

2025-10-23 Thread Sergey Bylokhov
> Please review the application of the `@Serial` annotation > ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the > java.security.jgss module to enable stricter compile-time checking of > serialization-related declarations. > > Example of a similar change https://github

Re: RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss

2025-10-23 Thread Sean Mullan
On Wed, 22 Oct 2025 01:10:00 GMT, Sergey Bylokhov wrote: > Please review the application of the `@Serial` annotation > ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the > java.security.jgss module to enable stricter compile-time checking of > serialization-related de

RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss

2025-10-21 Thread Sergey Bylokhov
Please review the application of the `@Serial` annotation ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the java.security.jgss module to enable stricter compile-time checking of serialization-related declarations. Example of a similar change https://github.com/openjdk

Re: RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss

2025-10-21 Thread Sergey Bylokhov
On Wed, 22 Oct 2025 01:10:00 GMT, Sergey Bylokhov wrote: > Please review the application of the `@Serial` annotation > ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the > java.security.jgss module to enable stricter compile-time checking of > serialization-related de