Re: RFR: 8358316: PKCS8Key.getEncoded() can throw NPE after JDK-8298420

2025-06-03 Thread Aleksey Shipilev
On Mon, 2 Jun 2025 10:26:58 GMT, Aleksey Shipilev wrote: > Found by static analysis, see more details in the bug. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `jdk_security` Here goes! - PR Comment: https://git.openjdk.org/jdk/pull/25581#issuecomment-2934062135

Re: RFR: 8358316: PKCS8Key.getEncoded() can throw NPE after JDK-8298420

2025-06-02 Thread Anthony Scarpino
On Mon, 2 Jun 2025 10:26:58 GMT, Aleksey Shipilev wrote: > Found by static analysis, see more details in the bug. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `jdk_security` Tests pass - PR Comment: https://git.openjdk.org/jdk/pull/25581#issuecomment-2931860336

Re: RFR: 8358316: PKCS8Key.getEncoded() can throw NPE after JDK-8298420

2025-06-02 Thread Aleksey Shipilev
On Mon, 2 Jun 2025 10:26:58 GMT, Aleksey Shipilev wrote: > Found by static analysis, see more details in the bug. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `jdk_security` Thanks! I'll integrate once my day starts tomorrow. - PR Comment: https://git.openjdk.or

Re: RFR: 8358316: PKCS8Key.getEncoded() can throw NPE after JDK-8298420

2025-06-02 Thread Anthony Scarpino
On Mon, 2 Jun 2025 10:26:58 GMT, Aleksey Shipilev wrote: > Found by static analysis, see more details in the bug. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `jdk_security` I'm. sure this is fine, but let me run the regression tests before integration - PR Comm

Re: RFR: 8358316: PKCS8Key.getEncoded() can throw NPE after JDK-8298420

2025-06-02 Thread Anthony Scarpino
On Mon, 2 Jun 2025 10:26:58 GMT, Aleksey Shipilev wrote: > Found by static analysis, see more details in the bug. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `jdk_security` looks good - Marked as reviewed by ascarpino (Reviewer). PR Review: https://git.openjdk

RFR: 8358316: PKCS8Key.getEncoded() can throw NPE after JDK-8298420

2025-06-02 Thread Aleksey Shipilev
Found by static analysis, see more details in the bug. Additional testing: - [x] Linux x86_64 server fastdebug, `jdk_security` - Commit messages: - Fix Changes: https://git.openjdk.org/jdk/pull/25581/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25581&range=00 Issue: