Re: [jdk25] RFR: 8358171: Additional code coverage for PEM API

2025-06-10 Thread Anthony Scarpino
On Tue, 10 Jun 2025 07:26:54 GMT, Fernando Guallini wrote: > Hi all, > > This pull request contains a backport of commit > [b2e7cda6](https://github.com/openjdk/jdk/commit/b2e7cda6a0bd21fa3c4ffe2a67da4953f1ca3f1f) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The comm

Re: [jdk25] RFR: 8358171: Additional code coverage for PEM API

2025-06-10 Thread Rajan Halade
On Tue, 10 Jun 2025 07:26:54 GMT, Fernando Guallini wrote: > Hi all, > > This pull request contains a backport of commit > [b2e7cda6](https://github.com/openjdk/jdk/commit/b2e7cda6a0bd21fa3c4ffe2a67da4953f1ca3f1f) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The comm

[jdk25] RFR: 8358171: Additional code coverage for PEM API

2025-06-10 Thread Fernando Guallini
Hi all, This pull request contains a backport of commit [b2e7cda6](https://github.com/openjdk/jdk/commit/b2e7cda6a0bd21fa3c4ffe2a67da4953f1ca3f1f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Fernando Guallini on 6 Jun 2025 and was

Re: RFR: 8358171: Additional code coverage for PEM API [v5]

2025-06-05 Thread Anthony Scarpino
On Thu, 5 Jun 2025 10:20:40 GMT, Fernando Guallini wrote: >> The tests included in this PR add code coverage mainly to the following >> classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, >> EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are >> in

Re: RFR: 8358171: Additional code coverage for PEM API [v4]

2025-06-05 Thread Fernando Guallini
On Thu, 5 Jun 2025 08:56:42 GMT, Andrey Turbanov wrote: >> Fernando Guallini has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains nine additional >>

Re: RFR: 8358171: Additional code coverage for PEM API [v5]

2025-06-05 Thread Fernando Guallini
> The tests included in this PR add code coverage mainly to the following > classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, > EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are > included for RSAPSS, multithreading, _jdk.epkcs8.defaultAlgorithm_

Re: RFR: 8358171: Additional code coverage for PEM API [v4]

2025-06-05 Thread Andrey Turbanov
On Thu, 5 Jun 2025 08:14:15 GMT, Fernando Guallini wrote: >> The tests included in this PR add code coverage mainly to the following >> classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, >> EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are >> in

Re: RFR: 8358171: Additional code coverage for PEM API [v4]

2025-06-05 Thread Fernando Guallini
> The tests included in this PR add code coverage mainly to the following > classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, > EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are > included for RSAPSS, multithreading, _jdk.epkcs8.defaultAlgorithm_

Re: RFR: 8358171: Additional code coverage for PEM API [v3]

2025-06-05 Thread Fernando Guallini
On Thu, 5 Jun 2025 01:53:40 GMT, Anthony Scarpino wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add invalid PEM content test > > test/jdk/java/security/PEM/PEMData.java line 500: > >> 498: } >> 499:

Re: RFR: 8358171: Additional code coverage for PEM API [v3]

2025-06-04 Thread Anthony Scarpino
On Wed, 4 Jun 2025 16:49:11 GMT, Fernando Guallini wrote: >> The tests included in this PR add code coverage mainly to the following >> classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, >> EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are >> in

Re: RFR: 8358171: Additional code coverage for PEM API [v3]

2025-06-04 Thread Fernando Guallini
> The tests included in this PR add code coverage mainly to the following > classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, > EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are > included for RSAPSS, multithreading, _jdk.epkcs8.defaultAlgorithm_

Re: RFR: 8358171: Additional code coverage for PEM API [v2]

2025-06-04 Thread Fernando Guallini
> The tests included in this PR add code coverage mainly to the following > classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, > EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are > included for RSAPSS, multithreading, _jdk.epkcs8.defaultAlgorithm_

Re: RFR: 8358171: Additional code coverage for PEM API

2025-06-03 Thread Fernando Guallini
On Mon, 2 Jun 2025 23:46:23 GMT, Matthew Donovan wrote: >> The tests included in this PR add code coverage mainly to the following >> classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, >> EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are >> inclu

Re: RFR: 8358171: Additional code coverage for PEM API

2025-06-03 Thread Matthew Donovan
On Tue, 3 Jun 2025 09:43:38 GMT, Fernando Guallini wrote: >> test/jdk/java/security/PEM/PEMData.java line 49: >> >>> 47: +OO4oO0VNduC44gUN1nrk7/wdNSpL+xXNEX52Dsff+2RD/fop224ANvB >>> 48: -END PRIVATE KEY- >>> 49: """, KeyPair.class, "SunEC"); >> >> When possible,

Re: RFR: 8358171: Additional code coverage for PEM API

2025-06-03 Thread Fernando Guallini
On Mon, 2 Jun 2025 23:54:30 GMT, Matthew Donovan wrote: >> The tests included in this PR add code coverage mainly to the following >> classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, >> EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are >> inclu

Re: RFR: 8358171: Additional code coverage for PEM API

2025-06-02 Thread Matthew Donovan
On Mon, 2 Jun 2025 12:14:13 GMT, Fernando Guallini wrote: > The tests included in this PR add code coverage mainly to the following > classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, > EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are > includ

RFR: 8358171: Additional code coverage for PEM API

2025-06-02 Thread Fernando Guallini
The tests included in this PR add code coverage mainly to the following classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are included for RSAPSS, multithreading, _jdk.epkcs8.defaultAlgorithm_ property