Re: RFR: 8358159: Empty mode/padding in cipher transformations [v5]

2025-06-12 Thread Valerie Peng
On Tue, 10 Jun 2025 08:17:29 GMT, Varada M wrote: >> Varada M has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8358159: Empty mode/padding in cipher transformations > > Thanks all @varada1110 After checking various javadoc, security docu

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v5]

2025-06-10 Thread Varada M
On Sat, 7 Jun 2025 20:07:45 GMT, Varada M wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing done f

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v5]

2025-06-09 Thread Amit Kumar
On Sat, 7 Jun 2025 20:07:45 GMT, Varada M wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing done f

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v5]

2025-06-09 Thread Valerie Peng
On Sat, 7 Jun 2025 20:07:45 GMT, Varada M wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing done f

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v4]

2025-06-07 Thread Varada M
On Thu, 5 Jun 2025 21:20:58 GMT, Valerie Peng wrote: >> Varada M has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8358159: Empty mode/padding in cipher transformations > > src/java.base/share/classes/javax/crypto/Cipher.java line 460: >

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v5]

2025-06-07 Thread Varada M
> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" > throws NoSuchAlgorithmException. > This patch restores the behavior by ensuring that empty mode or padding > strings are interpreted as null. > > Testing done for : tier1 - fastdebug level (AIX) > > JBS: [JDK-8358159

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v4]

2025-06-05 Thread Valerie Peng
On Thu, 5 Jun 2025 11:30:42 GMT, Varada M wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing done f

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v4]

2025-06-05 Thread Varada M
> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" > throws NoSuchAlgorithmException. > This patch restores the behavior by ensuring that empty mode or padding > strings are interpreted as null. > > Testing done for : tier1 - fastdebug level (AIX) > > JBS: [JDK-8358159

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v3]

2025-06-05 Thread Varada M
On Wed, 4 Jun 2025 18:13:59 GMT, Valerie Peng wrote: >> src/java.base/share/classes/javax/crypto/Cipher.java line 393: >> >>> 391: this.suffix = suffix.toUpperCase(Locale.ENGLISH); >>> 392: this.mode = ((mode == null) || mode.isEmpty()) ? null : >>> mode; >>> 393:

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v3]

2025-06-04 Thread Valerie Peng
On Wed, 4 Jun 2025 18:06:33 GMT, Valerie Peng wrote: >> Varada M has updated the pull request incrementally with one additional >> commit since the last revision: >> >> whitespace error fix > > src/java.base/share/classes/javax/crypto/Cipher.java line 393: > >> 391: this.suffix =

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v3]

2025-06-04 Thread Valerie Peng
On Wed, 4 Jun 2025 10:37:28 GMT, Varada M wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing done f

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v3]

2025-06-04 Thread Valerie Peng
On Wed, 4 Jun 2025 10:37:28 GMT, Varada M wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing done f

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v3]

2025-06-04 Thread Valerie Peng
On Wed, 4 Jun 2025 13:39:50 GMT, Sean Mullan wrote: > @valeriepeng Can you also review this? Thanks. Yes, I have started looking at it. Was about to ask for a regression test, and you beat me to it. - PR Comment: https://git.openjdk.org/jdk/pull/25547#issuecomment-2940866076

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v3]

2025-06-04 Thread Sean Mullan
On Wed, 4 Jun 2025 10:37:28 GMT, Varada M wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing done f

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v3]

2025-06-04 Thread Amit Kumar
On Wed, 4 Jun 2025 10:37:28 GMT, Varada M wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing done f

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v3]

2025-06-04 Thread Varada M
> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" > throws NoSuchAlgorithmException. > This patch restores the behavior by ensuring that empty mode or padding > strings are interpreted as null. > > Testing done for : tier1 - fastdebug level (AIX) > > JBS: [JDK-8358159

Re: RFR: 8358159: Empty mode/padding in cipher transformations [v2]

2025-06-04 Thread Varada M
> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" > throws NoSuchAlgorithmException. > This patch restores the behavior by ensuring that empty mode or padding > strings are interpreted as null. > > Testing done for : tier1 - fastdebug level (AIX) > > JBS: [JDK-8358159

Re: RFR: 8358159: Empty mode/padding in cipher transformations

2025-06-02 Thread Sean Mullan
On Fri, 30 May 2025 12:40:51 GMT, Sean Mullan wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing do

Re: RFR: 8358159: Empty mode/padding in cipher transformations

2025-06-02 Thread Varada M
On Fri, 30 May 2025 12:40:51 GMT, Sean Mullan wrote: >> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" >> throws NoSuchAlgorithmException. >> This patch restores the behavior by ensuring that empty mode or padding >> strings are interpreted as null. >> >> Testing do

RFR: 8358159: empty mode/padding in cipher transformations.

2025-05-30 Thread Varada M
Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" throws NoSuchAlgorithmException. This patch restores the behavior by ensuring that empty mode or padding strings are interpreted as null. Testing done for : tier1 - fastdebug level JBS: [JDK-8358159](https://bugs.openjdk

Re: RFR: 8358159: Empty mode/padding in cipher transformations.

2025-05-30 Thread Sean Mullan
On Fri, 30 May 2025 12:06:21 GMT, Varada M wrote: > Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" > throws NoSuchAlgorithmException. > This patch restores the behavior by ensuring that empty mode or padding > strings are interpreted as null. > > Testing done for :