On Mon, 28 Apr 2025 14:48:34 GMT, Weijun Wang wrote:
>> Add 2 `MessageDigest` algorithms.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> test alias usage
Marked as reviewed by mullan (Reviewer).
-
PR Review:
On Tue, 29 Apr 2025 17:50:01 GMT, Valerie Peng wrote:
> Update CSR with the new names, e.g. with the output length suffix?
Thanks for reminding. Done.
-
PR Comment: https://git.openjdk.org/jdk/pull/24576#issuecomment-2839977324
On Mon, 28 Apr 2025 14:48:34 GMT, Weijun Wang wrote:
>> Add 2 `MessageDigest` algorithms.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> test alias usage
Update CSR with the new names, e.g. with the output length suffix?
On Mon, 28 Apr 2025 14:48:34 GMT, Weijun Wang wrote:
>> Add 2 `MessageDigest` algorithms.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> test alias usage
Changes look fine. However, we should probably caution about these b
On Mon, 28 Apr 2025 18:08:22 GMT, Weijun Wang wrote:
> I mainly don't like the current [hardcoded
> branches](https://github.com/openjdk/jdk/blob/c54fc08aa3c63e4b26dc5edb2436844dfd3bab7c/src/java.base/share/classes/sun/security/pkcs/PKCS7.java#L754)
> (and [this
> one](https://github.com/openj
On Mon, 28 Apr 2025 14:48:34 GMT, Weijun Wang wrote:
>> Add 2 `MessageDigest` algorithms.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> test alias usage
I mainly don't like the current [hardcoded
branches](https://github
On Mon, 28 Apr 2025 14:48:34 GMT, Weijun Wang wrote:
>> Add 2 `MessageDigest` algorithms.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> test alias usage
(I thought I clicked the "comment" botton last Friday, not sure what
> Add 2 `MessageDigest` algorithms.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
test alias usage
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24576/files
- new: https://git.openjdk.org/jdk/pull/24576/files/4
On Thu, 10 Apr 2025 15:30:28 GMT, Weijun Wang wrote:
> Add 2 `MessageDigest` algorithms.
I updated the names. I also changed the names in `KnownOID`. According to
https://csrc.nist.gov/Projects/Computer-Security-Objects-Register/Algorithm-Registration#Hash,
these OIDs are assigned to "Secure H
> Add 2 `MessageDigest` algorithms.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
new algorithm names
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24576/files
- new: https://git.openjdk.org/jdk/pull/24576/file
On Thu, 10 Apr 2025 15:30:28 GMT, Weijun Wang wrote:
> Add 2 `MessageDigest` algorithms.
I strongly support the names "SHAKE128-256" and "SHAKE256-512".
-
PR Comment: https://git.openjdk.org/jdk/pull/24576#issuecomment-2834807368
On Thu, 17 Apr 2025 17:17:15 GMT, Valerie Peng wrote:
> I will take a look~
Thanks.
I have 2 concerns on this feature:
1. These algorithms are mainly used in higher-level algorithms, mainly
signature algorithms. It seems seldom used on their owns. But again, even other
SHA-3 algorithms are no
On Thu, 10 Apr 2025 15:30:28 GMT, Weijun Wang wrote:
> Add 2 `MessageDigest` algorithms.
I will take a look~
-
PR Comment: https://git.openjdk.org/jdk/pull/24576#issuecomment-2813594903
Add 2 `MessageDigest` algorithms.
-
Commit messages:
- the change
Changes: https://git.openjdk.org/jdk/pull/24576/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24576&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8354305
Stats: 96 lines in 4 files changed: 93 ins
14 matches
Mail list logo
