Re: RFR: 8353671: Remove dead code missed in JDK-8350459

2025-04-10 Thread duke
On Thu, 3 Apr 2025 18:42:35 GMT, Volodymyr Paprotski wrote: > 8353671: Remove dead code missed in JDK-8350459 @vpaprotsk Your change (at version 6cc25c3373e6dbb18c9d1d37e8cfcb5e08e16ff7) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/

Re: RFR: 8353671: Remove dead code missed in JDK-8350459

2025-04-10 Thread Volodymyr Paprotski
On Mon, 7 Apr 2025 14:32:26 GMT, Sean Mullan wrote: > Also, the JBS issue needs an appropriate `noreg` label. Added `noreg-cleanup`, I think thats the best match (?) > Can you add a link to JDK-8350459 in the JBS issue? Its already a subtask of JDK-8350459, so its 'linked' in a way (though the

Re: RFR: 8353671: Remove dead code missed in JDK-8350459

2025-04-07 Thread Sean Mullan
On Thu, 3 Apr 2025 18:42:35 GMT, Volodymyr Paprotski wrote: > 8353671: Remove dead code missed in JDK-8350459 Also, the JBS issue needs an appropriate `noreg` label. - PR Comment: https://git.openjdk.org/jdk/pull/24423#issuecomment-2783550263

Re: RFR: 8353671: Remove dead code missed in JDK-8350459

2025-04-07 Thread Sean Mullan
On Thu, 3 Apr 2025 18:42:35 GMT, Volodymyr Paprotski wrote: > 8353671: Remove dead code missed in JDK-8350459 Can you add a link to JDK-8350459 in the JBS issue? Also, Tony is not available right now to review, so I reviewed and approved it. - Marked as reviewed by mullan (Review

Re: RFR: 8353671: Remove dead code missed in JDK-8350459

2025-04-04 Thread Volodymyr Paprotski
On Thu, 3 Apr 2025 18:42:35 GMT, Volodymyr Paprotski wrote: > 8353671: Remove dead code missed in JDK-8350459 @ascarpino If you wouldn't mind, should be a quick one :) - PR Comment: https://git.openjdk.org/jdk/pull/24423#issuecomment-2779414600

Re: RFR: 8353671: Remove dead code missed in JDK-8350459

2025-04-03 Thread Sandhya Viswanathan
On Thu, 3 Apr 2025 18:42:35 GMT, Volodymyr Paprotski wrote: > 8353671: Remove dead code missed in JDK-8350459 Marked as reviewed by sviswanathan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24423#pullrequestreview-2741373475

RFR: 8353671: Remove dead code missed in JDK-8350459

2025-04-03 Thread Volodymyr Paprotski
8353671: Remove dead code missed in JDK-8350459 - Commit messages: - remove dead code Changes: https://git.openjdk.org/jdk/pull/24423/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24423&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353671 Stats: 23 lines in 1 f