Re: RFR: 8353642: Deprecate networking permission classes for removal [v3]

2025-04-11 Thread Daniel Fuchs
> Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return some of the deprecated permissions. Daniel Fuchs has upda

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Michael McMahon
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 12:01:52 GMT, Daniel Jeliński wrote: > The GHA failure (Windows) appears to be related. Yes - I missed one windows specific file in my original patch. I have a test running in the CI and I am waiting for it to pass before updating the PR. - PR Comment: https://

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Jeliński
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 11:34:36 GMT, Alan Bateman wrote: >> Possibly. @AlanBateman may have some thoughts on this. > > I think we should at least consider deprecating URLConnection.getPermission > and HttpURLConnection.getPermission for removal, only because I don't > immediately see the advantage

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Alan Bateman
On Fri, 11 Apr 2025 11:30:54 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/java/net/HttpURLConnection.java line 617: >> >>> 615: * {@link java.security.AllPermission}. >>> 616: */ >>> 617: @Deprecated(since = "25") >> >> can this (and all other getPermission methods) be

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 11:10:10 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/java/security/CodeSource.java line 468: >> >>> 466: } >>> 467: @SuppressWarnings("removal") >>> 468: var result = this.sp.implies(that.sp); >> >> Will we need

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 10:45:20 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Missing white spaces > > src/java.base/share/classes/java/net/HttpURLConnection.java line 617: > >> 615: * {@l

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Jeliński
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Jeliński
On Fri, 11 Apr 2025 10:55:10 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Missing white spaces > > src/java.base/share/classes/java/security/CodeSource.java line 468: > >> 466:

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Jeliński
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
> Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return some of the deprecated permissions. Daniel Fuchs has upda

Re: RFR: 8353642: Deprecate networking permission classes for removal

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 09:00:05 GMT, Daniel Fuchs wrote: > Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return so

RFR: 8353642: Deprecate networking permission classes for removal

2025-04-11 Thread Daniel Fuchs
Please find her a patch that deprecate networking permission classes for removal. The method `URL::getPermission` now serves little purpose and is also deprecated. That method was overridden in subclasses and specified to return some of the deprecated permissions. - Commit message