Re: RFR: 8351566: Consolidate third party artifacts used in tests [v5]

2025-06-20 Thread Mikhail Yankelevich
> 8351566: Consolidate third party artifacts used in tests Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits: - Merge branch 'master' into JDK-8351566 - updated nss version - Merge branch 'master' into

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v4]

2025-06-20 Thread Mikhail Yankelevich
> 8351566: Consolidate third party artifacts used in tests Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merge branch 'master' into JDK-8351566 - Fernando's comments: * cleanup - minor:

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v3]

2025-05-23 Thread Mikhail Yankelevich
On Thu, 27 Mar 2025 16:55:01 GMT, Mikhail Yankelevich wrote: >> 8351566: Consolidate third party artifacts used in tests > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > Fernando's comments: > > * cleanup still

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v3]

2025-04-24 Thread Mikhail Yankelevich
On Thu, 27 Mar 2025 16:55:01 GMT, Mikhail Yankelevich wrote: >> 8351566: Consolidate third party artifacts used in tests > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > Fernando's comments: > > * cleanup Still

Re: RFR: 8351566: Consolidate third party artifacts used in tests

2025-04-05 Thread Mikhail Yankelevich
On Tue, 11 Mar 2025 15:15:39 GMT, Mikhail Yankelevich wrote: > 8351566: Consolidate third party artifacts used in tests test/jdk/sun/security/pkcs11/Provider/MultipleLogins.sh line 31: > 29: #jdk.test.lib.Platform > 30: #jdk.test.lib.Utils > 31: #jdk.test.lib.security.a

Re: RFR: 8351566: Consolidate third party artifacts used in tests

2025-04-04 Thread Matthew Donovan
On Tue, 11 Mar 2025 15:15:39 GMT, Mikhail Yankelevich wrote: > 8351566: Consolidate third party artifacts used in tests test/lib/jdk/test/lib/security/NSSArtifactFetcher.java line 44: > 42: final Class nssLibClass = getNssLibClass(osId); > 43: if(nssLibClass == null){ > 44:

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v2]

2025-03-27 Thread Mikhail Yankelevich
On Thu, 27 Mar 2025 13:33:37 GMT, Fernando Guallini wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor: imports fix > > test/lib/jdk/test/lib/security/artifacts/ThirdPartyArtifacts.java line 30: > >> 28

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v3]

2025-03-27 Thread Mikhail Yankelevich
> 8351566: Consolidate third party artifacts used in tests Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: Fernando's comments: * cleanup - Changes: - all: https://git.openjdk.org/jdk/pull/23988/files - n

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v2]

2025-03-27 Thread Fernando Guallini
On Tue, 18 Mar 2025 14:11:26 GMT, Mikhail Yankelevich wrote: >> 8351566: Consolidate third party artifacts used in tests > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor: imports fix test/lib/jdk/test/lib/secu

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v2]

2025-03-19 Thread Mikhail Yankelevich
On Tue, 18 Mar 2025 13:49:28 GMT, Roger Riggs wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor: imports fix > > test/jdk/sun/security/pkcs11/PKCS11Test.java line 45: > >> 43: import java.security.spec.

Re: RFR: 8351566: Consolidate third party artifacts used in tests

2025-03-18 Thread Roger Riggs
On Tue, 11 Mar 2025 15:15:39 GMT, Mikhail Yankelevich wrote: > 8351566: Consolidate third party artifacts used in tests test/jdk/sun/security/pkcs11/PKCS11Test.java line 45: > 43: import java.security.spec.ECGenParameterSpec; > 44: import java.security.spec.ECParameterSpec; > 45: import java.u

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v2]

2025-03-18 Thread Mikhail Yankelevich
> 8351566: Consolidate third party artifacts used in tests Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: minor: imports fix - Changes: - all: https://git.openjdk.org/jdk/pull/23988/files - new: https://git.o

Re: RFR: 8351566: Consolidate third party artifacts used in tests

2025-03-18 Thread Mikhail Yankelevich
On Thu, 13 Mar 2025 14:07:58 GMT, Matthew Donovan wrote: >> 8351566: Consolidate third party artifacts used in tests > > test/lib/jdk/test/lib/security/NSSArtifactFetcher.java line 69: > >> 67: } >> 68: >> 69: public static String getNSSLibDir(String library) throws Exception { > > You

RFR: 8351566: Consolidate third party artifacts used in tests

2025-03-18 Thread Mikhail Yankelevich
8351566: Consolidate third party artifacts used in tests - Commit messages: - merge, docks and changind to use fetchOne - merging master - merge conflict fix - changed method flow, made unused methods private - JDK-8351566: Consolidate third party artifacts used in tests Changes