Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v5]

2025-04-24 Thread Sean Coffey
On Thu, 17 Apr 2025 15:25:36 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v5]

2025-04-23 Thread Bradford Wetmore
On Thu, 17 Apr 2025 15:25:36 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v4]

2025-04-17 Thread Sean Coffey
On Mon, 14 Apr 2025 23:59:39 GMT, Bradford Wetmore wrote: > > This bug only handles the `ssl` change, so I'm thinking we should change the > regtest for this bug to be a simple test looking for the effects of `ssl` > with no `data/verbose/plaintext/packet` output, and move (or update) this >

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v5]

2025-04-17 Thread Sean Coffey
> Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for backporting also. > > Wider corrections can be followe

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v4]

2025-04-14 Thread Bradford Wetmore
On Mon, 14 Apr 2025 18:42:40 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v3]

2025-04-14 Thread Sean Coffey
On Thu, 10 Apr 2025 03:11:42 GMT, Bradford Wetmore wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate latest review feedback > > Depending on the followup discussion of what `ssl` alone means. > > Howeve

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v4]

2025-04-14 Thread Sean Coffey
> Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for backporting also. > > Wider corrections can be followe

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v3]

2025-04-09 Thread Bradford Wetmore
On Thu, 6 Mar 2025 20:10:58 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v2]

2025-03-15 Thread Hai-May Chao
On Thu, 27 Feb 2025 20:21:28 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v3]

2025-03-06 Thread Hai-May Chao
On Thu, 6 Mar 2025 20:10:58 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v3]

2025-03-06 Thread Sean Coffey
> Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for backporting also. > > Wider corrections can be followe

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v2]

2025-03-06 Thread Hai-May Chao
On Thu, 27 Feb 2025 20:21:28 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v2]

2025-03-06 Thread Sean Coffey
On Thu, 6 Mar 2025 16:20:19 GMT, Kevin Driver wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Feedback from Mikhail > > test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java line 105: > >> 103:

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v2]

2025-03-06 Thread Kevin Driver
On Thu, 27 Feb 2025 20:21:28 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug

2025-02-27 Thread Mikhail Yankelevich
On Thu, 27 Feb 2025 20:18:38 GMT, Sean Coffey wrote: > Thanks for the feedback @myankelev - changes incorporated Thanks, LGTM - PR Comment: https://git.openjdk.org/jdk/pull/23781#issuecomment-2689188485

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug

2025-02-27 Thread Sean Coffey
On Tue, 25 Feb 2025 16:20:59 GMT, Sean Coffey wrote: > Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v2]

2025-02-27 Thread Sean Coffey
> Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for backporting also. > > Wider corrections can be followe

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug

2025-02-27 Thread Mikhail Yankelevich
On Tue, 25 Feb 2025 16:20:59 GMT, Sean Coffey wrote: > Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for

RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug

2025-02-25 Thread Sean Coffey
Breaking the parent JDK-8044609 JBS issue into sub tasks. This patch addresses the main issue which is that `javax.net.debug=ssl ` option is completely broken since TLSv1.3 support was introduced. This patch should be easier for backporting also. Wider corrections can be followed up via paren