Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v6]

2025-04-10 Thread Weijun Wang
On Wed, 19 Mar 2025 18:08:40 GMT, Mikhail Yankelevich wrote: >> Moved the sh file logic to jtreg java test. > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor: space at the end test/jdk/sun/security/pkcs11/Provi

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v6]

2025-04-09 Thread Matthew Donovan
On Wed, 19 Mar 2025 18:08:40 GMT, Mikhail Yankelevich wrote: >> Moved the sh file logic to jtreg java test. > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor: space at the end test/jdk/sun/security/pkcs11/Provi

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v6]

2025-04-09 Thread Weijun Wang
On Wed, 19 Mar 2025 18:08:40 GMT, Mikhail Yankelevich wrote: >> Moved the sh file logic to jtreg java test. > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor: space at the end test/jdk/sun/security/pkcs11/Provi

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v6]

2025-04-08 Thread Mikhail Yankelevich
On Wed, 19 Mar 2025 18:08:40 GMT, Mikhail Yankelevich wrote: >> Moved the sh file logic to jtreg java test. > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor: space at the end Still needs a review

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v6]

2025-03-19 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: minor: space at the end - Changes: - all: https://git.openjdk.org/jdk/pull/23590/files - new: https://git.openjdk.o

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v5]

2025-03-19 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: added summary - Changes: - all: https://git.openjdk.org/jdk/pull/23590/files - new: https://git.openjdk.org/jdk/pul

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v3]

2025-03-11 Thread Mikhail Yankelevich
On Tue, 25 Feb 2025 17:50:53 GMT, Mikhail Yankelevich wrote: >> test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 63: >> >>> 61: private static final SunPKCS11[] providers = new >>> SunPKCS11[NUM_PROVIDERS]; >>> 62: >>> 63: private static void copyDbFiles() throws IOExcep

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v4]

2025-03-11 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: Multiple logins test now extends PKCS11Test * Multiple logins test now extends PKCS11Test * cleanup * skip exceptions are no

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v3]

2025-02-25 Thread Mikhail Yankelevich
On Fri, 14 Feb 2025 15:07:50 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed to use a scratch directory > > test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 63: > >> 6

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v3]

2025-02-14 Thread Weijun Wang
On Thu, 13 Feb 2025 13:48:26 GMT, Mikhail Yankelevich wrote: >> Moved the sh file logic to jtreg java test. > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > changed to use a scratch directory test/jdk/sun/security/pk

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v3]

2025-02-13 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: changed to use a scratch directory - Changes: - all: https://git.openjdk.org/jdk/pull/23590/files - new: https://gi

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v2]

2025-02-13 Thread Mikhail Yankelevich
On Wed, 12 Feb 2025 19:31:31 GMT, Rajan Halade wrote: >> test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 63: >> >>> 61: private static void copyDbFiles() throws IOException { >>> 62: final var testFolder = System.getProperty("test.src", "."); >>> 63: final var

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v2]

2025-02-12 Thread Rajan Halade
On Wed, 12 Feb 2025 19:15:46 GMT, Rajan Halade wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed the year > > test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 63: > >> 61: private st

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v2]

2025-02-12 Thread Rajan Halade
On Wed, 12 Feb 2025 18:07:48 GMT, Mikhail Yankelevich wrote: >> Moved the sh file logic to jtreg java test. > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > changed the year Changes requested by rhalade (Reviewer).

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v2]

2025-02-12 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: changed the year - Changes: - all: https://git.openjdk.org/jdk/pull/23590/files - new: https://git.openjdk.org/jdk/

RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test

2025-02-12 Thread Mikhail Yankelevich
Moved the sh file logic to jtreg java test. - Commit messages: - 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test Changes: https://git.openjdk.org/jdk/pull/23590/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23590&range=00 Issue: https://bugs.openjdk.o