Re: RFR: 8349533: Refactor validator tests shell files to java [v6]

2025-02-24 Thread Weijun Wang
On Mon, 24 Feb 2025 20:08:12 GMT, Mikhail Yankelevich wrote: >> Changed shell files to be java tests: >> * ./validator/certreplace.sh >> * ./validator/samedn.sh > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > missing

Re: RFR: 8349533: Refactor validator tests shell files to java [v6]

2025-02-24 Thread duke
On Mon, 24 Feb 2025 20:08:12 GMT, Mikhail Yankelevich wrote: >> Changed shell files to be java tests: >> * ./validator/certreplace.sh >> * ./validator/samedn.sh > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > missing

Re: RFR: 8349533: Refactor validator tests shell files to java [v6]

2025-02-24 Thread Mikhail Yankelevich
> Changed shell files to be java tests: > * ./validator/certreplace.sh > * ./validator/samedn.sh Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: missing close file - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: 8349533: Refactor validator tests shell files to java [v4]

2025-02-24 Thread Weijun Wang
On Mon, 24 Feb 2025 17:24:51 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> othervm rm > > test/jdk/sun/security/validator/CertReplace.java line 205: > >> 203: >> 204: KeyStore ks

Re: RFR: 8349533: Refactor validator tests shell files to java [v5]

2025-02-24 Thread Mikhail Yankelevich
> Changed shell files to be java tests: > * ./validator/certreplace.sh > * ./validator/samedn.sh Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: cleanup - Changes: - all: https://git.openjdk.org/jdk/pull/23727/f

Re: RFR: 8349533: Refactor validator tests shell files to java [v4]

2025-02-24 Thread Weijun Wang
On Mon, 24 Feb 2025 16:47:32 GMT, Mikhail Yankelevich wrote: >> Changed shell files to be java tests: >> * ./validator/certreplace.sh >> * ./validator/samedn.sh > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > othervm

Re: RFR: 8349533: Refactor validator tests shell files to java [v4]

2025-02-24 Thread Mikhail Yankelevich
> Changed shell files to be java tests: > * ./validator/certreplace.sh > * ./validator/samedn.sh Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: othervm rm - Changes: - all: https://git.openjdk.org/jdk/pull/2372

Re: RFR: 8349533: Refactor validator tests shell files to java [v3]

2025-02-24 Thread Mikhail Yankelevich
> Changed shell files to be java tests: > * ./validator/certreplace.sh > * ./validator/samedn.sh Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: keyStore store and cleanup - Changes: - all: https://git.openjdk.o

Re: RFR: 8349533: Refactor validator tests shell files to java [v2]

2025-02-24 Thread Mikhail Yankelevich
On Fri, 21 Feb 2025 18:31:04 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> keyStore is not used to delete, cleanup of the calls, minor refactoring > > test/jdk/sun/security/validator/CertR

Re: RFR: 8349533: Refactor validator tests shell files to java [v2]

2025-02-21 Thread Weijun Wang
On Fri, 21 Feb 2025 16:57:32 GMT, Mikhail Yankelevich wrote: >> Changed shell files to be java tests: >> * ./validator/certreplace.sh >> * ./validator/samedn.sh > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > keyStor

Re: RFR: 8349533: Refactor validator tests shell files to java

2025-02-21 Thread Mikhail Yankelevich
On Fri, 21 Feb 2025 15:05:00 GMT, Weijun Wang wrote: >> Changed shell files to be java tests: >> * ./validator/certreplace.sh >> * ./validator/samedn.sh > > test/jdk/sun/security/validator/CertReplace.java line 117: > >> 115: final String outputInt = SecurityTools.keytool(ktBaseParameter

Re: RFR: 8349533: Refactor validator tests shell files to java [v2]

2025-02-21 Thread Mikhail Yankelevich
> Changed shell files to be java tests: > * ./validator/certreplace.sh > * ./validator/samedn.sh Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: keyStore is not used to delete, cleanup of the calls, minor refactoring -

Re: RFR: 8349533: Refactor validator tests shell files to java

2025-02-21 Thread Weijun Wang
On Fri, 21 Feb 2025 11:49:26 GMT, Mikhail Yankelevich wrote: > Changed shell files to be java tests: > * ./validator/certreplace.sh > * ./validator/samedn.sh test/jdk/sun/security/validator/CertReplace.java line 117: > 115: final String outputInt = SecurityTools.keytool(ktBaseParameters

RFR: 8349533: Refactor validator tests shell files to java

2025-02-21 Thread Mikhail Yankelevich
Changed shell files to be java tests: * ./validator/certreplace.sh * ./validator/samedn.sh - Commit messages: - changed to 2 different test ids - 8349533: Refactor validator tests shell files to java Changes: https://git.openjdk.org/jdk/pull/23727/files Webrev: https://webrevs.op