On Thu, 6 Feb 2025 19:31:24 GMT, Bradford Wetmore wrote:
>> Update and clarify the sample code.
>>
>> Docs only, no additional testing other than verifying javadoc is correctly
>> output.
>
> Bradford Wetmore has updated the pull request incrementally with one
> additional commit since the las
On Thu, 6 Feb 2025 19:31:24 GMT, Bradford Wetmore wrote:
>> Update and clarify the sample code.
>>
>> Docs only, no additional testing other than verifying javadoc is correctly
>> output.
>
> Bradford Wetmore has updated the pull request incrementally with one
> additional commit since the las
On Thu, 6 Feb 2025 21:21:36 GMT, Daniel Fuchs wrote:
>> `Convert UTF-8 bytes to the string with default ALPN encoding` also sounds
>> like an option.
>
> But we're not converting anything.
> What we do here is preserving the bytes encoded in UTF-8 by shoe-horning them
> into a string so that we
On Thu, 6 Feb 2025 19:47:54 GMT, Artur Barashev wrote:
>> I still think that `Convert to the default ALPN encoding` comment is less
>> confusing, we are just passing the string in the encoding that the library
>> expects. Basically your comment assumes reader's familiarity with the RFC.
>
> `Co
On Thu, 6 Feb 2025 19:35:22 GMT, Artur Barashev wrote:
>> RFC 7301 says:
>>
>> o Identification Sequence: The precise set of octet values that
>> identifies the protocol. This could be the UTF-8 encoding
>> [[RFC3629](https://datatracker.ietf.org/doc/html/rfc3629)] of the
>> p
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
minor wording tweak
-
Changes:
- all:
On Thu, 6 Feb 2025 19:23:55 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 666:
>>
>>> 664: * byte[] bytes = HUK_UN_I.getBytes(StandardCharsets.UTF_8);
>>> 665: *
>>> 666: * // Preserve network byte order by using ISO_8859
On Thu, 6 Feb 2025 19:10:04 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 666:
>
>> 664: *
On Tue, 4 Feb 2025 19:42:24 GMT, Bradford Wetmore wrote:
>> Update and clarify the sample code.
>>
>> Docs only, no additional testing other than verifying javadoc is correctly
>> output.
>
> Bradford Wetmore has updated the pull request incrementally with one
> additional commit since the las
On Tue, 4 Feb 2025 19:42:24 GMT, Bradford Wetmore wrote:
>> Update and clarify the sample code.
>>
>> Docs only, no additional testing other than verifying javadoc is correctly
>> output.
>
> Bradford Wetmore has updated the pull request incrementally with one
> additional commit since the las
On Wed, 5 Feb 2025 17:42:11 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 661:
>>
>>> 659: * // Encode 3 Meetei Mayek letters (HUK, UN, I) using Unicode
>>> Escapes
>>> 660: * // 0xabcd->0xabcf, 2 Unicode bytes/letter.
>>
On Wed, 5 Feb 2025 12:02:26 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 661:
>
>> 659: *
On Wed, 5 Feb 2025 12:03:52 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 672:
>>
>>> 670: * // Also, encode a two byte RFC 8701 GREASE ALPN value
>>> 671: * // e.g. 0x0A, 0x1A, 0x2A...0xFA
>>> 672: * String rfc8701Gr
On Tue, 4 Feb 2025 19:42:24 GMT, Bradford Wetmore wrote:
>> Update and clarify the sample code.
>>
>> Docs only, no additional testing other than verifying javadoc is correctly
>> output.
>
> Bradford Wetmore has updated the pull request incrementally with one
> additional commit since the las
On Wed, 5 Feb 2025 11:59:49 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 672:
>
>> 670: *
On Tue, 4 Feb 2025 17:18:09 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 668:
>
>> 666: *
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Codereview Comments
-
Changes:
- all:
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
On Fri, 31 Jan 2025 01:45:47 GMT, Bradford Wetmore wrote:
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 668:
> 666: * String encodedHukUn
Update and clarify the sample code.
Docs only, no additional testing other than verifying javadoc is correctly
output.
-
Commit messages:
- 8349121: SSLParameters.setApplicationProtocols() ALPN example could be
clarified
Changes: https://git.openjdk.org/jdk/pull/23379/files
Web
20 matches
Mail list logo
