On Fri, 28 Feb 2025 06:22:09 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request w
On Tue, 4 Mar 2025 11:11:44 GMT, Ferenc Rakoczi wrote:
>> Oops. sorry - cut and paste error -- the new setting should be
>>
>> do_arch_blob(compiler, 55000 ZGC_ONLY(+5000))
>
>> Oops. sorry - cut and paste error -- the new setting should be
>>
>> ```
>> do_arch_blob(compiler, 55000 ZGC_ONLY(+50
On Fri, 28 Feb 2025 06:22:09 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request w
On Tue, 4 Mar 2025 11:11:44 GMT, Ferenc Rakoczi wrote:
>> Oops. sorry - cut and paste error -- the new setting should be
>>
>> do_arch_blob(compiler, 55000 ZGC_ONLY(+5000))
>
>> Oops. sorry - cut and paste error -- the new setting should be
>>
>> ```
>> do_arch_blob(compiler, 55000 ZGC_ONLY(+50
On Fri, 28 Feb 2025 06:22:09 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request w
On Thu, 27 Feb 2025 09:53:21 GMT, Andrew Dinn wrote:
> Oops. sorry - cut and paste error -- the new setting should be
>
> ```
> do_arch_blob(compiler, 55000 ZGC_ONLY(+5000))
> ```
@adinn, I have done this change, but that erased your approval. Could you
reapprove?
-
PR Comment: h
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request with a new target base due to a
merge or a rebase. The pull requ
On Thu, 27 Feb 2025 10:15:48 GMT, Andrew Haley wrote:
>> OK, so GNU as is more forgiving than Apple as...
>
> Did my patch to aarch64-asmtest.py solve the problem?
I haven't tried, I just used GNU as.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23300#discussion_r197397035
On Tue, 25 Feb 2025 15:58:18 GMT, Ferenc Rakoczi wrote:
>> Aha!
>>
>>
>> aph@Andrews-MacBook-Pro ~ % as t.s
>> t.s:1:19: error: expected 'sxtx' 'uxtx' or 'lsl' with optional integer in
>> range [0, 4]
>> sub x1, x10, x23, sxth #2
>> ^
>> aph@Andrews-MacBook-Pro ~ % as --ve
On Wed, 26 Feb 2025 14:18:14 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Fri, 21 Feb 2025 10:23:37 GMT, Ferenc Rakoczi wrote:
>> Hi. Here is the test result of our CI.
>>
>> ### copyright year
>>
>> the following files should update the copyright year to 2025.
>>
>>
>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp
>> src/hotspot/cpu/aarch64/stubRoutines_aarch64
On Wed, 26 Feb 2025 14:18:14 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with two additional
commits since the last revisio
On Tue, 25 Feb 2025 13:50:35 GMT, Andrew Haley wrote:
>> I just tried it with top-of trunk latest binutils:
>>
>> fedora:aarch64 $ ~/binutils-gdb-install/bin/as
>> -march=armv9-a+sha3+sve2-bitperm aarch64ops.s
>> fedora:aarch64 $ ~/binutils-gdb-install/bin/as --version
>> GNU assembler (GNU Bin
On Tue, 25 Feb 2025 13:15:49 GMT, Andrew Haley wrote:
>>> I have not found the place in the manual where it allows/encourages the use
>>> of x instead of w, but I admit I > haven't read through all of the 14568
>>> pages.
>>
>> Yes, you've got a point, but it's always worked. Is this a macos t
On Tue, 25 Feb 2025 11:15:39 GMT, Ferenc Rakoczi wrote:
>>> You might have to use an assembler from the latest binutils build (if the
>>> system default isn't the latest) and add the path to the assembler in the
>>> "AS" variable. Also you can run it something like - `python
>>> aarch64-asmtes
On Tue, 25 Feb 2025 13:14:52 GMT, Andrew Haley wrote:
>> @theRealAlph, maybe we are not reading the same manual (ARM DDI 0487K.a). In
>> my copy:
>> SUB (extended register) is defined as
>> SUB , , {, {#}}
>> and should be W when is SXTH
>> and the as I have enforces this:
>>
>> ferakocz@fe
On Tue, 25 Feb 2025 09:36:49 GMT, Andrew Haley wrote:
>> @ferakocz This also really needs addressing before committing the patch.
>> Perhaps @theRealAph can advise on how to circumvent the problems you found
>> when trying to update the python script?
>
>> You might have to use an assembler fro
On Mon, 24 Feb 2025 17:11:24 GMT, Andrew Dinn wrote:
>> I have tried that, but the python script (actually the as command that it
>> started) threw error messages:
>>
>> aarch64ops.s:338:24: error: index must be a multiple of 8 in range [0,
>> 32760].
>> prfmPLDL1KEEP, [x15, 43]
>>
On Thu, 20 Feb 2025 17:33:18 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Thu, 20 Feb 2025 17:22:25 GMT, Ferenc Rakoczi wrote:
>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 2618:
>>
>>> 2616: INSN(smaxp, 0, 0b101001, false); // accepted arrangements: T8B,
>>> T16B, T4H, T8H, T2S, T4S
>>> 2617: INSN(sminp, 0, 0b101011, false); // accepted arrangements
On Thu, 20 Feb 2025 17:33:18 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Fri, 21 Feb 2025 10:23:37 GMT, Ferenc Rakoczi wrote:
>> Hi. Here is the test result of our CI.
>>
>> ### copyright year
>>
>> the following files should update the copyright year to 2025.
>>
>>
>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp
>> src/hotspot/cpu/aarch64/stubRoutines_aarch64
On Thu, 20 Feb 2025 17:33:18 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Thu, 20 Feb 2025 17:33:18 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Thu, 20 Feb 2025 17:33:18 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Thu, 20 Feb 2025 17:33:18 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Thu, 20 Feb 2025 17:33:18 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
On Thu, 20 Feb 2025 17:22:25 GMT, Ferenc Rakoczi wrote:
>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 2618:
>>
>>> 2616: INSN(smaxp, 0, 0b101001, false); // accepted arrangements: T8B,
>>> T16B, T4H, T8H, T2S, T4S
>>> 2617: INSN(sminp, 0, 0b101011, false); // accepted arrangements
On Mon, 24 Feb 2025 07:41:58 GMT, Hao Sun wrote:
>> @shqking, I changed the copyright years, but I don't really understand how
>> the aarch64-specific code can overflow buffers on other architectures. As
>> far as I understand, Instruction_aarch64 should not have been there in a ppc
>> build.
On Fri, 21 Feb 2025 10:23:37 GMT, Ferenc Rakoczi wrote:
> Was this a build attempted on an aarch64 for the other architectures?
Yes. It's a cross-build on AArch64 for other architectures.
> Instruction_aarch64 should not have been there in a ppc build
Oops. I didn't check the error message c
On Tue, 18 Feb 2025 13:43:18 GMT, Andrew Dinn wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comments + some code reorganization
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4066:
>
>> 4064
On Wed, 19 Feb 2025 02:55:18 GMT, Hao Sun wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comments + some code reorganization
>
> Hi. Here is the test result of our CI.
>
> ### copyright year
>
> the fol
On Tue, 18 Feb 2025 13:33:52 GMT, Andrew Dinn wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comments + some code reorganization
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 2594:
>
>> 2592:
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with four additional
commits since the last revisi
On Tue, 11 Feb 2025 10:40:31 GMT, Bhavana Kilambi wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comments + some code reorganization
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 2618:
>
>> 2616
On Tue, 4 Feb 2025 18:57:28 GMT, Ferenc Rakoczi wrote:
>>> @ferakocz I'm afraid you lucked out on getting your change committed before
>>> my reorganization of the stub generation code. If you are unsure of how to
>>> do the merge so your new stub is declared and generated following the new
>>
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
On Tue, 4 Feb 2025 18:57:28 GMT, Ferenc Rakoczi wrote:
>>> @ferakocz I'm afraid you lucked out on getting your change committed before
>>> my reorganization of the stub generation code. If you are unsure of how to
>>> do the merge so your new stub is declared and generated following the new
>>
On Mon, 3 Feb 2025 18:11:51 GMT, Ferenc Rakoczi wrote:
>> @ferakocz I'm afraid you lucked out on getting your change committed before
>> my reorganization of the stub generation code. If you are unsure of how to
>> do the merge so your new stub is declared and generated following the new
>> mo
On Mon, 3 Feb 2025 18:11:51 GMT, Ferenc Rakoczi wrote:
>> @ferakocz I'm afraid you lucked out on getting your change committed before
>> my reorganization of the stub generation code. If you are unsure of how to
>> do the merge so your new stub is declared and generated following the new
>> mo
On Thu, 30 Jan 2025 16:23:56 GMT, Andrew Dinn wrote:
> @ferakocz I'm afraid you lucked out on getting your change committed before
> my reorganization of the stub generation code. If you are unsure of how to do
> the merge so your new stub is declared and generated following the new model
> (s
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request with a new target base due to a
merge or a rebase. The pull requ
On Thu, 30 Jan 2025 16:14:27 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision
By using the aarch64 vector registers the speed of the computation of the
ML-DSA algorithms (key generation, document signing, signature verification)
can be approximately doubled.
-
Commit messages:
- fixing whitespace errors
- 8348561: Add aarch64 intrinsics for ML-DSA
Changes:
52 matches
Mail list logo
