Re: RFR: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests

2025-01-23 Thread Aleksey Shipilev
On Wed, 22 Jan 2025 16:59:04 GMT, Aleksey Shipilev wrote: > `Reference.waitForReferenceProcessing` is in internal API, which should go > away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There > is single use of that internal API in the tests, the last use of which was > re

Re: RFR: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests

2025-01-23 Thread Sean Mullan
On Thu, 23 Jan 2025 14:49:28 GMT, Aleksey Shipilev wrote: > I think I need another review for integration? Alan's review should be sufficient I think. The bug should have a `noreg-self` label. - PR Comment: https://git.openjdk.org/jdk/pull/23239#issuecomment-2610341728

Re: RFR: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests

2025-01-23 Thread Aleksey Shipilev
On Wed, 22 Jan 2025 16:59:04 GMT, Aleksey Shipilev wrote: > `Reference.waitForReferenceProcessing` is in internal API, which should go > away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There > is single use of that internal API in the tests, the last use of which was > re

Re: RFR: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests

2025-01-23 Thread Aleksey Shipilev
On Thu, 23 Jan 2025 10:54:23 GMT, Alan Bateman wrote: > So the test wasn't actually calling Reference::waitForReferenceProcessing, do > I have this right? In that case, this PR looks fine. Yup. The last use of `Reference::waitForReferenceProcessing` was removed by [JDK-8080225](https://bugs.op

Re: RFR: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests

2025-01-23 Thread Alan Bateman
On Wed, 22 Jan 2025 16:59:04 GMT, Aleksey Shipilev wrote: > `Reference.waitForReferenceProcessing` is in internal API, which should go > away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There > is single use of that internal API in the tests, the last use of which was > re

RFR: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests

2025-01-22 Thread Aleksey Shipilev
`Reference.waitForReferenceProcessing` is in internal API, which should go away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There is single use of that internal API in the tests, the last use of which was removed by [JDK-8080225](https://bugs.openjdk.org/browse/JDK-8080225).