Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection [v2]

2025-01-14 Thread Jaikiran Pai
On Tue, 14 Jan 2025 20:29:38 GMT, Daniel Fuchs wrote: >> There are a few places in the HttpClient code base where we close the >> connection when some error/exception happens. This can some time trigger a >> race condition where closing the connection in turns causes a "connection >> closed lo

Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection [v2]

2025-01-14 Thread Daniel Fuchs
On Tue, 14 Jan 2025 09:52:59 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review feedback from @japai > > src/java.net.http/share/classes/jdk/internal/net/http/Http1Response.java line > 334: >

Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection [v2]

2025-01-14 Thread Daniel Fuchs
> There are a few places in the HttpClient code base where we close the > connection when some error/exception happens. This can some time trigger a > race condition where closing the connection in turns causes a "connection > closed locally" exception to get reported instead of the original exc

Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection

2025-01-14 Thread Jaikiran Pai
On Mon, 13 Jan 2025 16:07:45 GMT, Daniel Fuchs wrote: > There are a few places in the HttpClient code base where we close the > connection when some error/exception happens. This can some time trigger a > race condition where closing the connection in turns causes a "connection > closed locall

Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection

2025-01-14 Thread Jaikiran Pai
On Mon, 13 Jan 2025 16:07:45 GMT, Daniel Fuchs wrote: > There are a few places in the HttpClient code base where we close the > connection when some error/exception happens. This can some time trigger a > race condition where closing the connection in turns causes a "connection > closed locall

RFR: 8347597: HttpClient: improve exception reporting when closing connection

2025-01-13 Thread Daniel Fuchs
There are a few places in the HttpClient code base where we close the connection when some error/exception happens. This can some time trigger a race condition where closing the connection in turns causes a "connection closed locally" exception to get reported instead of the original exception.