On Mon, 2 Dec 2024 13:43:41 GMT, Severin Gehwolf wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in Cgro
On Mon, 2 Dec 2024 13:39:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 14:07:45 GMT, Severin Gehwolf wrote:
>> Is the catch for `UncheckedIOException` due to some previously known failure
>> resulting in the use of these APIs?
>
> Without using `Files.lines()` no `UncheckedIOException` would be thrown. Just
> `IOException` and `null` returned. T
On Mon, 2 Dec 2024 14:03:10 GMT, Jaikiran Pai wrote:
>> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
>> line 70:
>>
>>> 68: String line = bufferedReader.readLine();
>>> 69: return line;
>>> 70: } catch (IOException e) {
>>
>>
On Mon, 2 Dec 2024 12:43:20 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in CgroupS
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 12:42:47 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in CgroupS
