On Tue, 26 Nov 2024 20:33:20 GMT, Valerie Peng wrote:
>> Could someone please help review this trivial fix?
>>
>> The constants for ML-KEM are accidentally removed during merge. This PR adds
>> them back and adds a test for checking them against the expected ones.
>
> Valerie Peng has updated t
On Tue, 26 Nov 2024 19:59:23 GMT, Valerie Peng wrote:
>> Could someone please help review this trivial fix?
>>
>> The constants for ML-KEM are accidentally removed during merge. This PR adds
>> them back and adds a test for checking them against the expected ones.
>
> Valerie Peng has updated t
> Could someone please help review this trivial fix?
>
> The constants for ML-KEM are accidentally removed during merge. This PR adds
> them back and adds a test for checking them against the expected ones.
Valerie Peng has updated the pull request incrementally with one additional
commit since
On Tue, 26 Nov 2024 19:59:23 GMT, Valerie Peng wrote:
>> Could someone please help review this trivial fix?
>>
>> The constants for ML-KEM are accidentally removed during merge. This PR adds
>> them back and adds a test for checking them against the expected ones.
>
> Valerie Peng has updated t
> Could someone please help review this trivial fix?
>
> The constants for ML-KEM are accidentally removed during merge. This PR adds
> them back and adds a test for checking them against the expected ones.
Valerie Peng has updated the pull request incrementally with one additional
commit since
On Tue, 26 Nov 2024 19:25:54 GMT, Sean Mullan wrote:
> A few small comments but this looks fine in order to get this fixed quickly.
> However, I think it would be better if there were ML-KEM and ML-DSA specific
> tests that used the public constants. I think we should followup on that with
> B
On Tue, 26 Nov 2024 19:04:47 GMT, Valerie Peng wrote:
> Could someone please help review this trivial fix?
>
> The constants for ML-KEM are accidentally removed during merge. This PR adds
> them back and adds a test for checking them against the expected ones.
A few small comments but this loo
Could someone please help review this trivial fix?
The constants for ML-KEM are accidentally removed during merge. This PR adds
them back and adds a test for checking them against the expected ones.
-
Commit messages:
- 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA
