Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp

2024-11-20 Thread Sean Mullan
On Tue, 19 Nov 2024 01:17:55 GMT, Brian Burkhalter wrote: > Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `jdk.sctp` module. src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 1085: > 1083: } > 1084: > 1085: @SuppressWarnings({"

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp [v2]

2024-11-19 Thread Brian Burkhalter
On Tue, 19 Nov 2024 16:33:49 GMT, Sean Mullan wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 836: Address reviewer comments > > src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 1085: >

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp [v2]

2024-11-19 Thread Brian Burkhalter
> Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `jdk.sctp` module. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 836: Address reviewer comments - Changes: - all: https

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp [v3]

2024-11-19 Thread Sean Mullan
On Tue, 19 Nov 2024 17:01:12 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `jdk.sctp` module. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 834

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp [v3]

2024-11-19 Thread Brian Burkhalter
> Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `jdk.sctp` module. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 836: Address more reviewer comments - Changes: - all:

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp [v2]

2024-11-19 Thread Sean Mullan
On Tue, 19 Nov 2024 16:21:11 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `jdk.sctp` module. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 834

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp [v2]

2024-11-19 Thread Alan Bateman
On Tue, 19 Nov 2024 16:21:11 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `jdk.sctp` module. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 834

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp [v2]

2024-11-19 Thread Brian Burkhalter
On Tue, 19 Nov 2024 13:57:01 GMT, Sean Mullan wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 836: Address reviewer comments > > src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 1085: >

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp

2024-11-19 Thread Brian Burkhalter
On Tue, 19 Nov 2024 07:30:01 GMT, Alan Bateman wrote: > [...] so in theory there may be code that modifies the set [...] That is precisely why I did not use `Set.of(saa)`. - PR Review Comment: https://git.openjdk.org/jdk/pull/5#discussion_r1848645515

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp

2024-11-18 Thread Alan Bateman
On Tue, 19 Nov 2024 01:17:55 GMT, Brian Burkhalter wrote: > Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `jdk.sctp` module. Marked as reviewed by alanb (Reviewer). src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpNet.java line 94: > 92: set =

Re: RFR: 8344446: Remove security manager dependency from module jdk.sctp

2024-11-18 Thread Brian Burkhalter
On Tue, 19 Nov 2024 01:17:55 GMT, Brian Burkhalter wrote: > Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `jdk.sctp` module. On a Linux system with SCTP, the results for the `com/sun/nio/sctp` tests are the same with this patch applied as without. -

RFR: 8344446: Remove security manager dependency from module jdk.sctp

2024-11-18 Thread Brian Burkhalter
Expunge the use of the `SecurityManager`, `AccessController`, and the like from the `jdk.sctp` module. - Commit messages: - 836: Remove security manager dependency from module jdk.sctp Changes: https://git.openjdk.org/jdk/pull/5/files Webrev: https://webrevs.openjdk.org/?