Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration [v4]

2024-11-15 Thread Jaikiran Pai
On Fri, 15 Nov 2024 14:07:10 GMT, Daniel Fuchs wrote: >> Please find here a patch that cleans up the java.net.http module code to >> remove permission checks and doPriviliged calls. >> This was mostly mechanical. > > Daniel Fuchs has updated the pull request incrementally with one additional >

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration [v4]

2024-11-15 Thread Daniel Fuchs
On Fri, 15 Nov 2024 09:10:51 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SimpleSSLContext.java >> line 45: >> >>> 43: * Creates a simple usable SSLContext for SSLSocketFactory >>> 44: * or a HttpsServer using a default keystore in the

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration [v3]

2024-11-15 Thread Daniel Fuchs
On Fri, 15 Nov 2024 13:15:42 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commit

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration [v4]

2024-11-15 Thread Daniel Fuchs
> Please find here a patch that cleans up the java.net.http module code to > remove permission checks and doPriviliged calls. > This was mostly mechanical. Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Jaikiran's feedback

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration [v3]

2024-11-15 Thread Jaikiran Pai
On Fri, 15 Nov 2024 10:25:18 GMT, Daniel Fuchs wrote: >> Please find here a patch that cleans up the java.net.http module code to >> remove permission checks and doPriviliged calls. >> This was mostly mechanical. > > Daniel Fuchs has updated the pull request with a new target base due to a > me

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration [v3]

2024-11-15 Thread Jaikiran Pai
On Fri, 15 Nov 2024 10:25:18 GMT, Daniel Fuchs wrote: >> Please find here a patch that cleans up the java.net.http module code to >> remove permission checks and doPriviliged calls. >> This was mostly mechanical. > > Daniel Fuchs has updated the pull request with a new target base due to a > me

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration [v3]

2024-11-15 Thread Daniel Fuchs
> Please find here a patch that cleans up the java.net.http module code to > remove permission checks and doPriviliged calls. > This was mostly mechanical. Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration [v2]

2024-11-15 Thread Daniel Fuchs
> Please find here a patch that cleans up the java.net.http module code to > remove permission checks and doPriviliged calls. > This was mostly mechanical. Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Review feedback

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration

2024-11-15 Thread Daniel Fuchs
On Thu, 14 Nov 2024 20:53:02 GMT, Michael McMahon wrote: >> Please find here a patch that cleans up the java.net.http module code to >> remove permission checks and doPriviliged calls. >> This was mostly mechanical. > > src/java.net.http/share/classes/jdk/internal/net/http/HttpClientBuilderImpl.

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration

2024-11-15 Thread Daniel Fuchs
On Thu, 14 Nov 2024 21:17:01 GMT, Michael McMahon wrote: >> Please find here a patch that cleans up the java.net.http module code to >> remove permission checks and doPriviliged calls. >> This was mostly mechanical. > > test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/Si

Re: RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration

2024-11-14 Thread Michael McMahon
On Thu, 14 Nov 2024 20:40:46 GMT, Daniel Fuchs wrote: > Please find here a patch that cleans up the java.net.http module code to > remove permission checks and doPriviliged calls. > This was mostly mechanical. Great cleanup! Good to see a lot of complicated cruft being removed. src/java.net.ht

RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration

2024-11-14 Thread Daniel Fuchs
Please find here a patch that cleans up the java.net.http module code to remove permission checks and doPriviliged calls. This was mostly mechanical. - Commit messages: - 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration Changes: https://git.openjdk