Re: RFR: 8344137: Update XML Security for Java to 3.0.5 [v2]

2024-12-09 Thread Sean Mullan
On Mon, 9 Dec 2024 17:43:00 GMT, Weijun Wang wrote: >> Update XML Signature to Apache Santuario 3.0.5. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > update to the test library class Marked as reviewed by mullan (Reviewer)

Re: RFR: 8344137: Update XML Security for Java to 3.0.5 [v2]

2024-12-09 Thread Weijun Wang
> Update XML Signature to Apache Santuario 3.0.5. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: update to the test library class - Changes: - all: https://git.openjdk.org/jdk/pull/22584/files - new: https://git.open

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-09 Thread Weijun Wang
On Thu, 5 Dec 2024 20:54:58 GMT, Weijun Wang wrote: > Update XML Signature to Apache Santuario 3.0.5. I've updated the `XMLUtils` helper class for internal testing. - PR Comment: https://git.openjdk.org/jdk/pull/22584#issuecomment-2528857923

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-06 Thread Weijun Wang
On Thu, 5 Dec 2024 20:54:58 GMT, Weijun Wang wrote: > Update XML Signature to Apache Santuario 3.0.5. Thanks. I've created the release note at https://bugs.openjdk.org/browse/JDK-8345729. - PR Comment: https://git.openjdk.org/jdk/pull/22584#issuecomment-2524223240

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-06 Thread Sean Mullan
On Thu, 5 Dec 2024 20:54:58 GMT, Weijun Wang wrote: > Update XML Signature to Apache Santuario 3.0.5. Looks good. Please write a release note noting the new SignatureMethod constants for ECDSA with SHA-3. - Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.o

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Weijun Wang
On Thu, 5 Dec 2024 23:18:51 GMT, Mark Powers wrote: > The only thing I noticed were old Oracle copyright dates in some files with > "dom" or "DOM" in their path names. Many contained a single 2005 but at least > one had 2005 plus another date that was not 2024. I don’t update the copyright yea

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Weijun Wang
On Thu, 5 Dec 2024 23:07:17 GMT, Mark Powers wrote: >> Update XML Signature to Apache Santuario 3.0.5. > > src/java.xml.crypto/share/legal/santuario.md line 226: > >> 224: >> 225: This product contains software that is >> 226: copyright (c) 2021, 2023, Oracle and/or its affiliates. > > Why not

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Mark Powers
On Thu, 5 Dec 2024 20:54:58 GMT, Weijun Wang wrote: > Update XML Signature to Apache Santuario 3.0.5. The only thing I noticed were old Oracle copyright dates in some files with "dom" or "DOM" in their path names. Many contained a single 2005 but at least one had 2005 plus another date that wa

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Mark Powers
On Thu, 5 Dec 2024 20:54:58 GMT, Weijun Wang wrote: > Update XML Signature to Apache Santuario 3.0.5. src/java.xml.crypto/share/legal/santuario.md line 226: > 224: > 225: This product contains software that is > 226: copyright (c) 2021, 2023, Oracle and/or its affiliates. Why not 2024? -

RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Weijun Wang
Update XML Signature to Apache Santuario 3.0.5. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/22584/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22584&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344137 Stats: 640 lines in 23 files ch