Re: [jdk24] RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set

2025-01-14 Thread Sean Mullan
On Mon, 13 Jan 2025 22:55:41 GMT, Weijun Wang wrote: > 8342062: Reformat keytool and jarsigner output for keys with a named > parameter set Marked as reviewed by mullan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23092#pullrequestreview-2549694680

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v6]

2025-01-10 Thread Sean Mullan
On Fri, 10 Jan 2025 16:13:14 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v6]

2025-01-10 Thread Weijun Wang
> Traditionally, an asymmetric key has a key size. The size is displayed by > `keytool` and `jarsigner`, both in informational output and weak-key > warnings. However, for the recently added ML-DSA algorithm, key size is not > defined. > > Thus when an ML-DSA key is created, `keytool` shows >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v5]

2025-01-10 Thread Weijun Wang
On Fri, 10 Jan 2025 14:36:11 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> one missing year change > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2068: > >> 2066:

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v5]

2025-01-10 Thread Sean Mullan
On Fri, 10 Jan 2025 01:01:28 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v5]

2025-01-09 Thread Weijun Wang
> Traditionally, an asymmetric key has a key size. The size is displayed by > `keytool` and `jarsigner`, both in informational output and weak-key > warnings. However, for the recently added ML-DSA algorithm, key size is not > defined. > > Thus when an ML-DSA key is created, `keytool` shows >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v4]

2025-01-09 Thread Weijun Wang
> Traditionally, an asymmetric key has a key size. The size is displayed by > `keytool` and `jarsigner`, both in informational output and weak-key > warnings. However, for the recently added ML-DSA algorithm, key size is not > defined. > > Thus when an ML-DSA key is created, `keytool` shows >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Weijun Wang
On Thu, 9 Jan 2025 19:19:11 GMT, Hai-May Chao wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> no more combined output > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2074: > >> 2072:

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Hai-May Chao
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Hai-May Chao
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Hai-May Chao
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Sean Mullan
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Sean Mullan
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-08 Thread Weijun Wang
On Wed, 8 Jan 2025 16:57:59 GMT, Mark Powers wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> no more combined output > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line > 1245: > >> 1243:

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-08 Thread Weijun Wang
On Wed, 8 Jan 2025 18:45:14 GMT, Kevin Driver wrote: > What is the process in cases like this where i18n needs to happen on the > `Resources` files? You will see commits like https://github.com/openjdk/jdk/commit/fd0207d59309ae1af9539580f5bfcbc7627789cb. A dedicated team, possibly supported b

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-08 Thread Kevin Driver
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-08 Thread Mark Powers
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2024-12-13 Thread Weijun Wang
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2024-12-13 Thread Weijun Wang
> Traditionally, an asymmetric key has a key size. The size is displayed by > `keytool` and `jarsigner`, both in informational output and weak-key > warnings. However, for the recently added ML-DSA algorithm, key size is not > defined. > > Thus when an ML-DSA key is created, `keytool` shows >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v2]

2024-12-13 Thread Weijun Wang
> Traditionally, an asymmetric key has a key size. The size is displayed by > `keytool` and `jarsigner`, both in informational output and weak-key > warnings. However, for the recently added ML-DSA algorithm, key size is not > defined. > > Thus when an ML-DSA key is created, `keytool` shows >

RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set

2024-12-13 Thread Weijun Wang
Traditionally, an asymmetric key has a key size. The size is displayed by `keytool` and `jarsigner`, both in informational output and weak-key warnings. However, for the recently added ML-DSA algorithm, key size is not defined. Thus when an ML-DSA key is created, `keytool` shows Generating -1 b