On Tue, 22 Oct 2024 15:48:54 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> more precise comment
Marked as reviewed by mullan (Reviewer).
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
more precise comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.org/jdk/pull
On Tue, 22 Oct 2024 14:27:19 GMT, Sean Mullan wrote:
>> The CRL is being constructed from a fuzzed data input stream. All I know is
>> that the name in the CertificateIssuerExtension looks like an x509.OIDName
>> in the first test, and in the second test it looks like an x509.X400Address.
>>
>
On Tue, 22 Oct 2024 12:51:45 GMT, Mark Powers wrote:
>> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedCCE.java line 46:
>>
>>> 44: // "class sun.security.x509.OIDName cannot be cast
>>> 45: // to class sun.security.x509.X500Name"
>>> 46: byte[] encoded_1 = Base64.getDe
On Mon, 21 Oct 2024 17:28:42 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more precise exception message
>
> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedCCE.java line 46:
>
>> 44: /
On Mon, 21 Oct 2024 17:12:04 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> more precise exception message
test/jdk/sun/security/x509/X509CRLImpl/Unexp
On Fri, 18 Oct 2024 13:40:38 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> allow more than one name
>
> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 296:
>
>> 294:
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
more precise exception message
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.or
On Fri, 18 Oct 2024 13:50:13 GMT, Sean Mullan wrote:
>> Does the test need to be modified to test for more than one name? I could go
>> either way.
>
> Are you able to easily create test CRLs with more than one entry? If not, I
> think the existing test is ok.
I know how to create a Certificat
On Tue, 8 Oct 2024 15:32:55 GMT, Mark Powers wrote:
>> Fixed.
>
> Does the test need to be modified to test for more than one name? I could go
> either way.
Are you able to easily create test CRLs with more than one entry? If not, I
think the existing test is ok.
-
PR Review Comm
On Tue, 8 Oct 2024 15:32:19 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> allow more than one name
src/java.base/share/classes/sun/security/x509/X509C
On Tue, 8 Oct 2024 15:28:58 GMT, Mark Powers wrote:
>> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 292:
>>
>>> 290: throw new CRLException("Parsing error: "
>>> 291: + "issuer is not an X.500 DN");
>>> 292: }
On Tue, 24 Sep 2024 12:33:54 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> another comment from Sean
>
> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 292:
>
>> 290:
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
allow more than one name
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.org/jdk/
On Wed, 11 Sep 2024 15:03:43 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> another comment from Sean
src/java.base/share/classes/sun/security/x509/X50
On Wed, 11 Sep 2024 13:26:27 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment from Sean
>
> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 290:
>
>> 288:
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
another comment from Sean
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.org/jdk
On Tue, 13 Aug 2024 15:30:09 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> comment from Sean
src/java.base/share/classes/sun/security/x509/X509CRLImpl
On Mon, 12 Aug 2024 19:20:17 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright and unnecessary initialization
>
> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 291:
>
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
comment from Sean
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.org/jdk/pull/20
On Mon, 12 Aug 2024 15:44:11 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> copyright and unnecessary initialization
src/java.base/share/classes/sun/se
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
copyright and unnecessary initialization
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.
On Fri, 9 Aug 2024 17:22:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8336665
Need to update copyright on X509CRLImpl.java.
-
PR Comment: https://git.openjdk.org/jdk/pull/20528#issuecomment-2278477735
https://bugs.openjdk.org/browse/JDK-8336665
-
Commit messages:
- first iteration
Changes: https://git.openjdk.org/jdk/pull/20528/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20528&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8336665
Stats: 88 lines in 2 files
24 matches
Mail list logo
