Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases [v4]

2024-09-09 Thread duke
On Mon, 9 Sep 2024 18:43:20 GMT, Artur Barashev wrote: >> https://bugs.openjdk.org/browse/JDK-8329754 > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright @artur-oracle Your change (at version eabc8779d6f90d

Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases [v4]

2024-09-09 Thread Weijun Wang
On Mon, 9 Sep 2024 18:43:20 GMT, Artur Barashev wrote: >> https://bugs.openjdk.org/browse/JDK-8329754 > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright Looks better! - Marked as reviewed by w

Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases [v4]

2024-09-09 Thread Artur Barashev
> https://bugs.openjdk.org/browse/JDK-8329754 Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Update copyright - Changes: - all: https://git.openjdk.org/jdk/pull/20916/files - new: https://git.openjdk.org/jdk/pull/

Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases [v3]

2024-09-09 Thread Weijun Wang
On Mon, 9 Sep 2024 17:59:36 GMT, Artur Barashev wrote: >> https://bugs.openjdk.org/browse/JDK-8329754 > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Code refactoring: using "List.of" and "Utils.runAndCheckException" Loo

Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases [v3]

2024-09-09 Thread Artur Barashev
On Mon, 9 Sep 2024 15:54:36 GMT, Weijun Wang wrote: >> Good idea, added more tests. Alternatively we could re-work the >> `GetInstance` utility class to store the real algo name, but then we should >> update all the callers of that class to use the real algorithm and not the >> (possible) alia

Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases [v3]

2024-09-09 Thread Artur Barashev
> https://bugs.openjdk.org/browse/JDK-8329754 Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Code refactoring: using "List.of" and "Utils.runAndCheckException" - Changes: - all: https://git.openjdk.org/jdk/pull/2091

Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases [v2]

2024-09-09 Thread Weijun Wang
On Mon, 9 Sep 2024 15:19:28 GMT, Artur Barashev wrote: >> test/jdk/java/security/SecureRandom/ThreadSafe.java line 77: >> >>> 75: //Bad. Alias of S2, should fail because S2 is marked as >>> ThreadSafe >>> 76: put("alg.Alias.SecureRandom.AliasS2", "S2"); >>> 77: >> >> W

Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases [v2]

2024-09-09 Thread Artur Barashev
On Mon, 9 Sep 2024 14:19:02 GMT, Weijun Wang wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adding more tests for algorithm alias > > test/jdk/java/security/SecureRandom/ThreadSafe.java line 77: > >> 75:

Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases [v2]

2024-09-09 Thread Artur Barashev
> https://bugs.openjdk.org/browse/JDK-8329754 Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Adding more tests for algorithm alias - Changes: - all: https://git.openjdk.org/jdk/pull/20916/files - new: https://git.

Re: RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases

2024-09-09 Thread Weijun Wang
On Mon, 9 Sep 2024 14:00:19 GMT, Artur Barashev wrote: > https://bugs.openjdk.org/browse/JDK-8329754 test/jdk/java/security/SecureRandom/ThreadSafe.java line 77: > 75: //Bad. Alias of S2, should fail because S2 is marked as > ThreadSafe > 76: put("alg.Alias.SecureRandom

RFR: 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases

2024-09-09 Thread Artur Barashev
https://bugs.openjdk.org/browse/JDK-8329754 - Commit messages: - 8329754: The ThreadSafe attribute is ignored for SecureRandom algorithm aliases Changes: https://git.openjdk.org/jdk/pull/20916/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20916&range=00 Issue: https://