Re: RFR: 8328957: Update PKCS11Test.java to not use hardcoded path [v2]

2024-04-03 Thread Rajan Halade
On Tue, 26 Mar 2024 17:48:49 GMT, Matthew Donovan wrote: >> When resolving the location of the NSS library, the code appended a >> hard-coded path: `/nss/lib`. This makes it difficult for a person to specify >> the library when it is installed in a location such as `/usr/lib64`. >> >> In this

Re: RFR: 8328957: Update PKCS11Test.java to not use hardcoded path [v2]

2024-03-26 Thread Martin Balao
On Tue, 26 Mar 2024 17:48:49 GMT, Matthew Donovan wrote: >> When resolving the location of the NSS library, the code appended a >> hard-coded path: `/nss/lib`. This makes it difficult for a person to specify >> the library when it is installed in a location such as `/usr/lib64`. >> >> In this

Re: RFR: 8328957: Update PKCS11Test.java to not use hardcoded path [v2]

2024-03-26 Thread Matthew Donovan
On Tue, 26 Mar 2024 16:31:06 GMT, Martin Balao wrote: > Hi @mpdonova , > > Thanks for contributing this fix. I've seen in java.nio.file.Files::find doc > an implementation note saying that it should be used in a try-with-resource > fashion to close the stream and any open directories. Should w

Re: RFR: 8328957: Update PKCS11Test.java to not use hardcoded path [v2]

2024-03-26 Thread Matthew Donovan
> When resolving the location of the NSS library, the code appended a > hard-coded path: `/nss/lib`. This makes it difficult for a person to specify > the library when it is installed in a location such as `/usr/lib64`. > > In this PR, I removed the hard-coded path and updated the code to searc

Re: RFR: 8328957: Update PKCS11Test.java to not use hardcoded path

2024-03-26 Thread Martin Balao
On Tue, 26 Mar 2024 14:02:27 GMT, Matthew Donovan wrote: > When resolving the location of the NSS library, the code appended a > hard-coded path: `/nss/lib`. This makes it difficult for a person to specify > the library when it is installed in a location such as `/usr/lib64`. > > In this PR,

RFR: 8328957: Update PKCS11Test.java to not use hardcoded path

2024-03-26 Thread Matthew Donovan
When resolving the location of the NSS library, the code appended a hard-coded path: `/nss/lib`. This makes it difficult for a person to specify the library when it is installed in a location such as `/usr/lib64`. In this PR, I removed the hard-coded path and updated the code to search the spe