Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc [v3]

2024-04-09 Thread Ben Perez
> Removed `PrivateKeyUsagePeriod` from method javadoc and added several > commonly used extensions Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Added Authority Information Access OID - Changes: - all: https://git.open

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc [v3]

2024-04-09 Thread Sean Mullan
On Tue, 9 Apr 2024 19:59:37 GMT, Ben Perez wrote: >> Removed `PrivateKeyUsagePeriod` from method javadoc and added several >> commonly used extensions > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Added Authority Informatio

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc [v2]

2024-04-04 Thread Bradford Wetmore
On Wed, 3 Apr 2024 19:06:22 GMT, Ben Perez wrote: >> Removed `PrivateKeyUsagePeriod` from method javadoc and added several >> commonly used extensions > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Updated copyright Marked

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc [v2]

2024-04-04 Thread Sean Mullan
On Wed, 3 Apr 2024 19:06:22 GMT, Ben Perez wrote: >> Removed `PrivateKeyUsagePeriod` from method javadoc and added several >> commonly used extensions > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Updated copyright Marked

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc [v2]

2024-04-03 Thread Ben Perez
> Removed `PrivateKeyUsagePeriod` from method javadoc and added several > commonly used extensions Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Updated copyright - Changes: - all: https://git.openjdk.org/jdk/pull/1856

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc

2024-04-03 Thread Sean Mullan
On Mon, 1 Apr 2024 17:39:07 GMT, Ben Perez wrote: > Removed `PrivateKeyUsagePeriod` from method javadoc and added several > commonly used extensions Looks good other than the copyright date. - Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc

2024-04-03 Thread Sean Mullan
On Mon, 1 Apr 2024 17:39:07 GMT, Ben Perez wrote: > Removed `PrivateKeyUsagePeriod` from method javadoc and added several > commonly used extensions src/java.base/share/classes/java/security/cert/X509Extension.java line 1: > 1: /* Update the copyright date to 2024. - PR Review C

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc

2024-04-03 Thread Rajan Halade
On Mon, 1 Apr 2024 17:39:07 GMT, Ben Perez wrote: > Removed `PrivateKeyUsagePeriod` from method javadoc and added several > commonly used extensions /request_review @seanjmullan - PR Comment: https://git.openjdk.org/jdk/pull/18565#issuecomment-2035269620

RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc

2024-04-01 Thread Ben Perez
Removed `PrivateKeyUsagePeriod` from method javadoc and added several commonly used extensions - Commit messages: - removed PrivateKeyUsagePeriod from table and added several other commonly used extensions Changes: https://git.openjdk.org/jdk/pull/18565/files Webrev: https://web