On Wed, 26 Jun 2024 23:01:50 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a review of this clean backport of this test fix to jdk23.
>
> Tony
Marked as reviewed by rhalade (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19917#pullrequestreview-2145507373
Hi,
I need a review of this clean backport of this test fix to jdk23.
Tony
-
Commit messages:
- Backport 4ffc5e60776353b03e9a557c39148e378b1690e2
Changes: https://git.openjdk.org/jdk/pull/19917/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19917&range=00
Issue: https:
On Wed, 5 Jun 2024 02:57:41 GMT, Anthony Scarpino wrote:
> Hi,
>
> I need a review for this simple change to fix a threading problem with the
> test. The server thread was not completing before the check occurred on the
> main thread. The failure showed up in windows and macos, but not linux.
On Wed, 5 Jun 2024 02:57:41 GMT, Anthony Scarpino wrote:
> Hi,
>
> I need a review for this simple change to fix a threading problem with the
> test. The server thread was not completing before the check occurred on the
> main thread. The failure showed up in windows and macos, but not linux.
On Thu, 6 Jun 2024 14:28:25 GMT, Mark Powers wrote:
>> I have never heard that. I have always ended with a plus and I believe
>> everyone else does too if I'm not mistaken.
>
> https://cr.openjdk.org/~alundblad/styleguide/index-v6.html#toc-constants
>
> Probably showed up in a code review comm
On Wed, 5 Jun 2024 23:49:02 GMT, Anthony Scarpino wrote:
>> test/jdk/javax/net/ssl/templates/TLSBase.java line 246:
>>
>>> 244: void done() {
>>> 245: try {
>>> 246: t.join(5000);
>>
>> I had to increase the join value of a test recently that failed with virt
On Wed, 5 Jun 2024 23:48:56 GMT, Anthony Scarpino wrote:
>> test/jdk/javax/net/ssl/templates/TLSBase.java line 101:
>>
>>> 99: if (!empty) {
>>> 100: fis = new FileInputStream(System.getProperty("test.src",
>>> "./") +
>>> 101: "/" + pathToStores + "/" + keyS
On Wed, 5 Jun 2024 19:57:34 GMT, Mark Powers wrote:
>> Hi,
>>
>> I need a review for this simple change to fix a threading problem with the
>> test. The server thread was not completing before the check occurred on the
>> main thread. The failure showed up in windows and macos, but not linux.
On Wed, 5 Jun 2024 02:57:41 GMT, Anthony Scarpino wrote:
> Hi,
>
> I need a review for this simple change to fix a threading problem with the
> test. The server thread was not completing before the check occurred on the
> main thread. The failure showed up in windows and macos, but not linux.
Hi,
I need a review for this simple change to fix a threading problem with the
test. The server thread was not completing before the check occurred on the
main thread. The failure showed up in windows and macos, but not linux. With
this fix, running 100 times, windows & macos showed no failur
10 matches
Mail list logo
