Re: RFR: 8322766: Micro bench SSLHandshake would use modern algorithms [v2]

2024-01-02 Thread Sean Mullan
On Sat, 30 Dec 2023 00:48:00 GMT, John Jiang wrote: >> test/micro/org/openjdk/bench/java/security/SSLHandshake.java is using >> keystore type `JKS` and TrustManagerFactory/KeyManagerFactory algorithm >> `SunX509`. >> It may be better to use `PKCS12` and `PKIX` respectively. > > John Jiang has u

Re: RFR: 8322766: Micro bench SSLHandshake would use modern algorithms [v2]

2023-12-30 Thread John Jiang
On Sat, 30 Dec 2023 09:20:59 GMT, Daniel Jeliński wrote: > Users usually use the default algorithms, so benchmarking them is probably > more useful than measuring the non-default ones. I see. > There's a [ticket to update the default keyManager > algorithm](https://bugs.openjdk.org/browse/JDK

Re: RFR: 8322766: Micro bench SSLHandshake would use modern algorithms [v2]

2023-12-30 Thread Daniel Jeliński
On Sat, 30 Dec 2023 00:48:00 GMT, John Jiang wrote: >> test/micro/org/openjdk/bench/java/security/SSLHandshake.java is using >> keystore type `JKS` and TrustManagerFactory/KeyManagerFactory algorithm >> `SunX509`. >> It may be better to use `PKCS12` and `PKIX` respectively. > > John Jiang has u

Re: RFR: 8322766: Micro bench SSLHandshake would use modern algorithms

2023-12-29 Thread John Jiang
On Fri, 29 Dec 2023 19:13:57 GMT, Daniel Jeliński wrote: >> test/micro/org/openjdk/bench/java/security/SSLHandshake.java is using >> keystore type `JKS` and TrustManagerFactory/KeyManagerFactory algorithm >> `SunX509`. >> It may be better to use `PKCS12` and `PKIX` respectively. > > Could you c

Re: RFR: 8322766: Micro bench SSLHandshake would use modern algorithms [v2]

2023-12-29 Thread John Jiang
> test/micro/org/openjdk/bench/java/security/SSLHandshake.java is using > keystore type `JKS` and TrustManagerFactory/KeyManagerFactory algorithm > `SunX509`. > It may be better to use `PKCS12` and `PKIX` respectively. John Jiang has updated the pull request incrementally with one additional co

Re: RFR: 8322766: Micro bench SSLHandshake would use modern algorithms

2023-12-29 Thread Daniel Jeliński
On Fri, 29 Dec 2023 06:49:26 GMT, John Jiang wrote: > test/micro/org/openjdk/bench/java/security/SSLHandshake.java is using > keystore type `JKS` and TrustManagerFactory/KeyManagerFactory algorithm > `SunX509`. > It may be better to use `PKCS12` and `PKIX` respectively. Could you change to get

RFR: 8322766: Micro bench SSLHandshake would use modern algorithms

2023-12-28 Thread John Jiang
test/micro/org/openjdk/bench/java/security/SSLHandshake.java is using keystore type `JKS` and TrustManagerFactory/KeyManagerFactory algorithm `SunX509`. It may be better to use `PKCS12` and `PKIX` respectively. - Commit messages: - 8322766: Micro bench SSLHandshake would use modern