Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v3]

2024-01-16 Thread Sean Mullan
On Mon, 15 Jan 2024 03:37:45 GMT, John Jiang wrote: >> ECDHKeyAgreement should validate the parameters before assigning them to the >> fields. > > John Jiang has updated the pull request incrementally with one additional > commit since the last revision: > > Not use JUnit test/jdk/sun/secur

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v3]

2024-01-14 Thread John Jiang
On Sun, 14 Jan 2024 19:09:57 GMT, Sean Mullan wrote: >> I originally didn't depend on JUnit. But this tool can easily execute >> multiple test cases independently. >> A single failed case doesn't make the whole test fail fast, and all cases >> always be executed. > > Fair point, although there

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v3]

2024-01-14 Thread John Jiang
> ECDHKeyAgreement should validate the parameters before assigning them to the > fields. John Jiang has updated the pull request incrementally with one additional commit since the last revision: Not use JUnit - Changes: - all: https://git.openjdk.org/jdk/pull/17373/files - n